From: Reinette Chatre <reinette.chatre@intel.com>
To: Babu Moger <babu.moger@amd.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"fenghua.yu@intel.com" <fenghua.yu@intel.com>,
"bp@alien8.de" <bp@alien8.de>,
"tony.luck@intel.com" <tony.luck@intel.com>
Cc: "kuo-lang.tseng@intel.com" <kuo-lang.tseng@intel.com>,
"ravi.v.shankar@intel.com" <ravi.v.shankar@intel.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 3/4] x86/resctrl: Enable per-thread MBA
Date: Sat, 16 May 2020 11:03:24 -0700 [thread overview]
Message-ID: <2e04ff69-d246-82dd-12b9-83a1f36fccfa@intel.com> (raw)
In-Reply-To: <bb5b518c-2a10-1e0b-9c7d-29e58093a04a@amd.com>
Hi Babu,
On 5/14/2020 12:04 PM, Babu Moger wrote:
>
>
>> -----Original Message-----
>> From: Reinette Chatre <reinette.chatre@intel.com>
>> Sent: Wednesday, May 6, 2020 6:50 PM
>> To: tglx@linutronix.de; fenghua.yu@intel.com; bp@alien8.de;
>> tony.luck@intel.com
>> Cc: kuo-lang.tseng@intel.com; ravi.v.shankar@intel.com; mingo@redhat.com;
>> Moger, Babu <Babu.Moger@amd.com>; hpa@zytor.com; x86@kernel.org;
>> linux-kernel@vger.kernel.org; Reinette Chatre <reinette.chatre@intel.com>
>> Subject: [PATCH V3 3/4] x86/resctrl: Enable per-thread MBA
>>
>> From: Fenghua Yu <fenghua.yu@intel.com>
>>
...
>> static int rdt_thread_throttle_mode_show(struct kernfs_open_file *of,
>> struct seq_file *seq, void *v)
>> {
>> unsigned int throttle_mode = 0;
>>
>> + if (boot_cpu_has(X86_FEATURE_PER_THREAD_MBA)) {
>> + seq_puts(seq, "per-thread\n");
>> +
> You probably don't need an extra line here.
>
This area looks slightly different after moving to a resource property
but unnecessary extra lines will be removed.
Thank you very much
Reinette
next prev parent reply other threads:[~2020-05-16 18:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 23:49 [PATCH V3 0/4] x86/resctrl: Enable user to view and select thread throttling mode Reinette Chatre
2020-05-06 23:49 ` [PATCH V3 1/4] " Reinette Chatre
2020-05-14 16:45 ` Babu Moger
2020-05-14 18:10 ` Reinette Chatre
2020-05-14 20:06 ` Babu Moger
2020-05-16 18:00 ` Reinette Chatre
2020-05-06 23:49 ` [PATCH V3 2/4] x86/resctrl: Enumerate per-thread MBA Reinette Chatre
2020-05-14 19:04 ` Babu Moger
2020-05-14 20:12 ` Reinette Chatre
2020-05-14 20:41 ` Babu Moger
2020-05-06 23:49 ` [PATCH V3 3/4] x86/resctrl: Enable " Reinette Chatre
2020-05-14 19:04 ` Babu Moger
2020-05-16 18:03 ` Reinette Chatre [this message]
2020-05-06 23:49 ` [PATCH V3 4/4] x86/resctrl: Use appropriate API for strings terminated by newline Reinette Chatre
2020-05-14 19:05 ` Babu Moger
2020-05-14 19:11 ` Andy Shevchenko
2020-05-14 20:06 ` Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e04ff69-d246-82dd-12b9-83a1f36fccfa@intel.com \
--to=reinette.chatre@intel.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=kuo-lang.tseng@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®