From: Babu Moger <babu.moger@amd.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"fenghua.yu@intel.com" <fenghua.yu@intel.com>,
"bp@alien8.de" <bp@alien8.de>,
"tony.luck@intel.com" <tony.luck@intel.com>
Cc: "kuo-lang.tseng@intel.com" <kuo-lang.tseng@intel.com>,
"ravi.v.shankar@intel.com" <ravi.v.shankar@intel.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V3 2/4] x86/resctrl: Enumerate per-thread MBA
Date: Thu, 14 May 2020 15:41:35 -0500 [thread overview]
Message-ID: <90198198-4ab9-867e-e14f-ecede9035e98@amd.com> (raw)
In-Reply-To: <e8b35231-f94e-ba25-125d-12819478bb24@intel.com>
> -----Original Message-----
> From: Reinette Chatre <reinette.chatre@intel.com>
> Sent: Thursday, May 14, 2020 3:12 PM
> To: Moger, Babu <Babu.Moger@amd.com>; tglx@linutronix.de;
> fenghua.yu@intel.com; bp@alien8.de; tony.luck@intel.com
> Cc: kuo-lang.tseng@intel.com; ravi.v.shankar@intel.com; mingo@redhat.com;
> hpa@zytor.com; x86@kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH V3 2/4] x86/resctrl: Enumerate per-thread MBA
>
> Hi Babu,
>
> On 5/14/2020 12:04 PM, Babu Moger wrote:
> >
> >
> >> -----Original Message-----
> >> From: Reinette Chatre <reinette.chatre@intel.com>
> >> Sent: Wednesday, May 6, 2020 6:50 PM
> >> To: tglx@linutronix.de; fenghua.yu@intel.com; bp@alien8.de;
> >> tony.luck@intel.com
> >> Cc: kuo-lang.tseng@intel.com; ravi.v.shankar@intel.com;
> mingo@redhat.com;
> >> Moger, Babu <Babu.Moger@amd.com>; hpa@zytor.com; x86@kernel.org;
> >> linux-kernel@vger.kernel.org; Reinette Chatre <reinette.chatre@intel.com>
> >> Subject: [PATCH V3 2/4] x86/resctrl: Enumerate per-thread MBA
> >>
> >> From: Fenghua Yu <fenghua.yu@intel.com>
> >>
>
> ...
>
> >> diff --git a/arch/x86/kernel/cpu/scattered.c
> b/arch/x86/kernel/cpu/scattered.c
> >> index 62b137c3c97a..bccfc9ff3cc1 100644
> >> --- a/arch/x86/kernel/cpu/scattered.c
> >> +++ b/arch/x86/kernel/cpu/scattered.c
> >> @@ -35,6 +35,7 @@ static const struct cpuid_bit cpuid_bits[] = {
> >> { X86_FEATURE_CDP_L3, CPUID_ECX, 2, 0x00000010, 1
> >> },
> >> { X86_FEATURE_CDP_L2, CPUID_ECX, 2, 0x00000010, 2
> >> },
> >> { X86_FEATURE_MBA, CPUID_EBX, 3, 0x00000010, 0 },
> >> + { X86_FEATURE_PER_THREAD_MBA, CPUID_ECX, 0, 0x00000010, 3
> >> },
> >
> > This is a CPUID feature. You can actually detect this feature without
> > checking vendor model in patch @1. This patch looks good to me.
> >
>
> This feature is different from the feature introduced in patch 1.
Ok. I mis-understood that.
next prev parent reply other threads:[~2020-05-14 20:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 23:49 [PATCH V3 0/4] x86/resctrl: Enable user to view and select thread throttling mode Reinette Chatre
2020-05-06 23:49 ` [PATCH V3 1/4] " Reinette Chatre
2020-05-14 16:45 ` Babu Moger
2020-05-14 18:10 ` Reinette Chatre
2020-05-14 20:06 ` Babu Moger
2020-05-16 18:00 ` Reinette Chatre
2020-05-06 23:49 ` [PATCH V3 2/4] x86/resctrl: Enumerate per-thread MBA Reinette Chatre
2020-05-14 19:04 ` Babu Moger
2020-05-14 20:12 ` Reinette Chatre
2020-05-14 20:41 ` Babu Moger [this message]
2020-05-06 23:49 ` [PATCH V3 3/4] x86/resctrl: Enable " Reinette Chatre
2020-05-14 19:04 ` Babu Moger
2020-05-16 18:03 ` Reinette Chatre
2020-05-06 23:49 ` [PATCH V3 4/4] x86/resctrl: Use appropriate API for strings terminated by newline Reinette Chatre
2020-05-14 19:05 ` Babu Moger
2020-05-14 19:11 ` Andy Shevchenko
2020-05-14 20:06 ` Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90198198-4ab9-867e-e14f-ecede9035e98@amd.com \
--to=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=kuo-lang.tseng@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®