From: Joshua Kinard <kumba@gentoo.org>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
David Binderman <linuxdev.baldrick@gmail.com>
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org, dcb314@hotmail.com
Subject: Re: linux-4.7-rc2/drivers/rtc/rtc-ds1685.c: 2 * bad if test ?
Date: Tue, 7 Jun 2016 18:12:04 -0400 [thread overview]
Message-ID: <2e0e2f2f-6e19-6727-fbc2-0712e32da18e@gentoo.org> (raw)
In-Reply-To: <20160607153027.GK3363@piout.net>
On 06/07/2016 11:30, Alexandre Belloni wrote:
> Hi,
>
> On 07/06/2016 at 16:18:31 +0100, David Binderman wrote :
>> Hello there,
>>
[snip]
>> Duplicate. Also in the same file:
>>
>> [drivers/rtc/rtc-ds1685.c:265]: (style) Variable 'ctrlb' is assigned a
>> value that is never used.
This looks like it can be removed. I believe it's a relic of before I added
the handling of either BCD or Binary modes for the SGI Octane's RTC interface.
>> [drivers/rtc/rtc-ds1685.c:812]: (style) Variable 'ctrlc' is assigned a
>> value that is never used.
This needs to be wrapped in #ifdef CONFIG_RTC_DS1685_PROC_REGS, as the value of
'ctrlc' is displayed in /proc/drivers/rtc if that kconfig option is selected on
supported systems.
--
Joshua Kinard
Gentoo/MIPS
kumba@gentoo.org
6144R/F5C6C943 2015-04-27
177C 1972 1FB8 F254 BAD0 3E72 5C63 F4E3 F5C6 C943
"The past tempts us, the present confuses us, the future frightens us. And our
lives slip away, moment by moment, lost in that vast, terrible in-between."
--Emperor Turhan, Centauri Republic
prev parent reply other threads:[~2016-06-07 22:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 15:18 David Binderman
2016-06-07 15:30 ` Alexandre Belloni
2016-06-07 22:12 ` Joshua Kinard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e0e2f2f-6e19-6727-fbc2-0712e32da18e@gentoo.org \
--to=kumba@gentoo.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=dcb314@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxdev.baldrick@gmail.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®