* [PATCH] wifi: cfg80211: convert timeouts to secs_to_jiffies()
@ 2025-02-19 20:32 Easwar Hariharan
2025-02-21 18:31 ` Jeff Johnson
0 siblings, 1 reply; 2+ messages in thread
From: Easwar Hariharan @ 2025-02-19 20:32 UTC (permalink / raw)
To: Johannes Berg, open list:802.11 (including CFG80211/NL80211), open list
Cc: Easwar Hariharan
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced
secs_to_jiffies(). As the value here is a multiple of 1000, use
secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication.
This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with
the following Coccinelle rules:
@depends on patch@
expression E;
@@
-msecs_to_jiffies(E * 1000)
+secs_to_jiffies(E)
-msecs_to_jiffies(E * MSEC_PER_SEC)
+secs_to_jiffies(E)
Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>
---
net/wireless/scan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/wireless/scan.c b/net/wireless/scan.c
index cd2124329521..1de25e9763cb 100644
--- a/net/wireless/scan.c
+++ b/net/wireless/scan.c
@@ -1365,7 +1365,7 @@ void cfg80211_bss_age(struct cfg80211_registered_device *rdev,
unsigned long age_secs)
{
struct cfg80211_internal_bss *bss;
- unsigned long age_jiffies = msecs_to_jiffies(age_secs * MSEC_PER_SEC);
+ unsigned long age_jiffies = secs_to_jiffies(age_secs);
spin_lock_bh(&rdev->bss_lock);
list_for_each_entry(bss, &rdev->bss_list, list)
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] wifi: cfg80211: convert timeouts to secs_to_jiffies()
2025-02-19 20:32 [PATCH] wifi: cfg80211: convert timeouts to secs_to_jiffies() Easwar Hariharan
@ 2025-02-21 18:31 ` Jeff Johnson
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Johnson @ 2025-02-21 18:31 UTC (permalink / raw)
To: Easwar Hariharan, Johannes Berg,
open list:802.11 (including CFG80211/NL80211),
open list
On 2/19/2025 12:32 PM, Easwar Hariharan wrote:
> Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced
> secs_to_jiffies(). As the value here is a multiple of 1000, use
> secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication.
>
> This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with
> the following Coccinelle rules:
>
> @depends on patch@
> expression E;
> @@
>
> -msecs_to_jiffies(E * 1000)
> +secs_to_jiffies(E)
>
> -msecs_to_jiffies(E * MSEC_PER_SEC)
> +secs_to_jiffies(E)
>
> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>
> ---
> net/wireless/scan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/wireless/scan.c b/net/wireless/scan.c
> index cd2124329521..1de25e9763cb 100644
> --- a/net/wireless/scan.c
> +++ b/net/wireless/scan.c
> @@ -1365,7 +1365,7 @@ void cfg80211_bss_age(struct cfg80211_registered_device *rdev,
> unsigned long age_secs)
> {
> struct cfg80211_internal_bss *bss;
> - unsigned long age_jiffies = msecs_to_jiffies(age_secs * MSEC_PER_SEC);
> + unsigned long age_jiffies = secs_to_jiffies(age_secs);
>
> spin_lock_bh(&rdev->bss_lock);
> list_for_each_entry(bss, &rdev->bss_list, list)
Reviewed-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-21 18:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-19 20:32 [PATCH] wifi: cfg80211: convert timeouts to secs_to_jiffies() Easwar Hariharan
2025-02-21 18:31 ` Jeff Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®