[PATCH v4] dt-bindings: power: Convert raspberrypi,bcm2835-power to Dt schema

[PATCH v4] dt-bindings: power: Convert raspberrypi,bcm2835-power to Dt schema

[Karan Sanghavi]

Convert the raspberrypi,bcm2835-power binding to Dt schema

Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
---
Changes in v4:
- Corrected misindentations and random differences.
- Link to v3: https://lore.kernel.org/r/20241026-raspberrypi-bcm2835-power-v3-1-6621e075d33f@gmail.com

Changes in v3:
- Applied changes as per the feedback received for title and description
- Removed power label and renamed node to power-controller	
- Moved the file from bindings/soc/bcm to bindings/power
- Link to v2: https://lore.kernel.org/r/20241022-raspberrypi-bcm2835-power-v2-1-1a4a8a8a5737@gmail.com

Changes in v2:
- Added original file maintainers
- Removed unnecessary headers from example and formating from description 
- Link to v1: https://lore.kernel.org/r/20241019-raspberrypi-bcm2835-power-v1-1-75e924dc3745@gmail.com
---
 .../bindings/power/raspberrypi,bcm2835-power.yaml  | 42 +++++++++++++++++++
 .../bindings/soc/bcm/raspberrypi,bcm2835-power.txt | 47 ----------------------
 2 files changed, 42 insertions(+), 47 deletions(-)

diff --git a/Documentation/devicetree/bindings/power/raspberrypi,bcm2835-power.yaml b/Documentation/devicetree/bindings/power/raspberrypi,bcm2835-power.yaml
new file mode 100644
index 000000000000..259e1d9b3fab
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/raspberrypi,bcm2835-power.yaml
@@ -0,0 +1,42 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/raspberrypi,bcm2835-power.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom BCM2835 power domain
+
+maintainers:
+  - Alexander Aring <alex.aring@gmail.com>
+  - Eric Anholt <eric@anholt.net>
+
+description:
+  The Raspberry Pi power domain manages power for various subsystems
+  in the Raspberry Pi BCM2835 SoC.
+
+properties:
+  compatible:
+    enum:
+      - raspberrypi,bcm2835-power
+
+  firmware:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: Reference to the RPi firmware device node
+
+  "#power-domain-cells":
+    const: 1
+
+required:
+  - compatible
+  - firmware
+  - "#power-domain-cells"
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    power-controller {
+      compatible = "raspberrypi,bcm2835-power";
+      firmware = <&firmware>;
+      #power-domain-cells = <1>;
+    };
diff --git a/Documentation/devicetree/bindings/soc/bcm/raspberrypi,bcm2835-power.txt b/Documentation/devicetree/bindings/soc/bcm/raspberrypi,bcm2835-power.txt
deleted file mode 100644
index 30942cf7992b..000000000000
--- a/Documentation/devicetree/bindings/soc/bcm/raspberrypi,bcm2835-power.txt
+++ /dev/null
@@ -1,47 +0,0 @@
-Raspberry Pi power domain driver
-
-Required properties:
-
-- compatible:		Should be "raspberrypi,bcm2835-power".
-- firmware:		Reference to the RPi firmware device node.
-- #power-domain-cells:	Should be <1>, we providing multiple power domains.
-
-The valid defines for power domain are:
-
- RPI_POWER_DOMAIN_I2C0
- RPI_POWER_DOMAIN_I2C1
- RPI_POWER_DOMAIN_I2C2
- RPI_POWER_DOMAIN_VIDEO_SCALER
- RPI_POWER_DOMAIN_VPU1
- RPI_POWER_DOMAIN_HDMI
- RPI_POWER_DOMAIN_USB
- RPI_POWER_DOMAIN_VEC
- RPI_POWER_DOMAIN_JPEG
- RPI_POWER_DOMAIN_H264
- RPI_POWER_DOMAIN_V3D
- RPI_POWER_DOMAIN_ISP
- RPI_POWER_DOMAIN_UNICAM0
- RPI_POWER_DOMAIN_UNICAM1
- RPI_POWER_DOMAIN_CCP2RX
- RPI_POWER_DOMAIN_CSI2
- RPI_POWER_DOMAIN_CPI
- RPI_POWER_DOMAIN_DSI0
- RPI_POWER_DOMAIN_DSI1
- RPI_POWER_DOMAIN_TRANSPOSER
- RPI_POWER_DOMAIN_CCP2TX
- RPI_POWER_DOMAIN_CDP
- RPI_POWER_DOMAIN_ARM
-
-Example:
-
-power: power {
-	compatible = "raspberrypi,bcm2835-power";
-	firmware = <&firmware>;
-	#power-domain-cells = <1>;
-};
-
-Example for using power domain:
-
-&usb {
-       power-domains = <&power RPI_POWER_DOMAIN_USB>;
-};

---
base-commit: 8e929cb546ee42c9a61d24fae60605e9e3192354
change-id: 20241019-raspberrypi-bcm2835-power-5a4231be8959

Best regards,
-- 
Karan Sanghavi <karansanghvi98@gmail.com>

Re: [PATCH v4] dt-bindings: power: Convert raspberrypi,bcm2835-power to Dt schema

[Krzysztof Kozlowski]

On Mon, Oct 28, 2024 at 04:44:12PM +0000, Karan Sanghavi wrote:
> Convert the raspberrypi,bcm2835-power binding to Dt schema
> 
> Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
> ---
> Changes in v4:
> - Corrected misindentations and random differences.
> - Link to v3: https://lore.kernel.org/r/20241026-raspberrypi-bcm2835-power-v3-1-6621e075d33f@gmail.com

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

<form letter>
This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
</form letter>

Best regards,
Krzysztof

Re: [PATCH v4] dt-bindings: power: Convert raspberrypi,bcm2835-power to Dt schema

[Karan Sanghavi]

On Tue, Oct 29, 2024 at 08:10:23AM +0100, Krzysztof Kozlowski wrote:
> On Mon, Oct 28, 2024 at 04:44:12PM +0000, Karan Sanghavi wrote:
> > Convert the raspberrypi,bcm2835-power binding to Dt schema
> > 
> > Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
> > ---
> > Changes in v4:
> > - Corrected misindentations and random differences.
> > - Link to v3: https://lore.kernel.org/r/20241026-raspberrypi-bcm2835-power-v3-1-6621e075d33f@gmail.com
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> <form letter>
> This is an automated instruction, just in case, because many review tags
> are being ignored. If you know the process, you can skip it (please do
> not feel offended by me posting it here - no bad intentions intended).
> If you do not know the process, here is a short explanation:
> 
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions, under or above your Signed-off-by tag. Tag is "received", when
> provided in a message replied to you on the mailing list. Tools like b4
> can help here. However, there's no need to repost patches *only* to add
> the tags. The upstream maintainer will do that for tags received on the
> version they apply.
> 
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
> </form letter>
> 
> Best regards,
> Krzysztof
>

Dear Krzysztof,

I hope this email finds you well. 
I'm following up on the patch I recently submitted linked below.
https://lore.kernel.org/all/ZxEm-H-PjlQyXeOH@Emma/
I noticed it hasn't been applied yet, and I wanted to see if there was 
anything else needed from my end. 
Please let me know if any further information or modifications are required.  
I appreciate your time and feedback.  

Thank you! 

Sincerely,
Karan.

Re: [PATCH v4] dt-bindings: power: Convert raspberrypi,bcm2835-power to Dt schema

[Krzysztof Kozlowski]

On 24/11/2024 09:49, Karan Sanghavi wrote:
> On Tue, Oct 29, 2024 at 08:10:23AM +0100, Krzysztof Kozlowski wrote:
>> On Mon, Oct 28, 2024 at 04:44:12PM +0000, Karan Sanghavi wrote:
>>> Convert the raspberrypi,bcm2835-power binding to Dt schema
>>>
>>> Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
>>> ---
>>> Changes in v4:
>>> - Corrected misindentations and random differences.
>>> - Link to v3: https://lore.kernel.org/r/20241026-raspberrypi-bcm2835-power-v3-1-6621e075d33f@gmail.com
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> <form letter>
>> This is an automated instruction, just in case, because many review tags
>> are being ignored. If you know the process, you can skip it (please do
>> not feel offended by me posting it here - no bad intentions intended).
>> If you do not know the process, here is a short explanation:
>>
>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
>> versions, under or above your Signed-off-by tag. Tag is "received", when
>> provided in a message replied to you on the mailing list. Tools like b4
>> can help here. However, there's no need to repost patches *only* to add
>> the tags. The upstream maintainer will do that for tags received on the
>> version they apply.
>>
>> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
>> </form letter>
>>
>> Best regards,
>> Krzysztof
>>
> 
> Dear Krzysztof,
> 
> I hope this email finds you well. 
> I'm following up on the patch I recently submitted linked below.
> https://lore.kernel.org/all/ZxEm-H-PjlQyXeOH@Emma/
I don't understand why do you reply to this patch about other patch.
Anyway, you got reply there.

Best regards,
Krzysztof

Re: [PATCH v4] dt-bindings: power: Convert raspberrypi,bcm2835-power to Dt schema

[Karan Sanghavi]

On Sun, Nov 24, 2024 at 11:52:35AM +0100, Krzysztof Kozlowski wrote:
> On 24/11/2024 09:49, Karan Sanghavi wrote:
> > On Tue, Oct 29, 2024 at 08:10:23AM +0100, Krzysztof Kozlowski wrote:
> >> On Mon, Oct 28, 2024 at 04:44:12PM +0000, Karan Sanghavi wrote:
> >>> Convert the raspberrypi,bcm2835-power binding to Dt schema
> >>>
> >>> Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
> >>> ---
> >>> Changes in v4:
> >>> - Corrected misindentations and random differences.
> >>> - Link to v3: https://lore.kernel.org/r/20241026-raspberrypi-bcm2835-power-v3-1-6621e075d33f@gmail.com
> >>
> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>
> >> ---
> >>
> >> <form letter>
> >> This is an automated instruction, just in case, because many review tags
> >> are being ignored. If you know the process, you can skip it (please do
> >> not feel offended by me posting it here - no bad intentions intended).
> >> If you do not know the process, here is a short explanation:
> >>
> >> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> >> versions, under or above your Signed-off-by tag. Tag is "received", when
> >> provided in a message replied to you on the mailing list. Tools like b4
> >> can help here. However, there's no need to repost patches *only* to add
> >> the tags. The upstream maintainer will do that for tags received on the
> >> version they apply.
> >>
> >> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
> >> </form letter>
> >>
> >> Best regards,
> >> Krzysztof
> >>
> > 
> > Dear Krzysztof,
> > 
> > I hope this email finds you well. 
> > I'm following up on the patch I recently submitted linked below.
> > https://lore.kernel.org/all/ZxEm-H-PjlQyXeOH@Emma/
> I don't understand why do you reply to this patch about other patch.
> Anyway, you got reply there.
>
Really sorry to attach the wrong link 
Please find the corret link below
https://lore.kernel.org/all/20241028-raspberrypi-bcm2835-power-v4-1-acf44abd45ff@gmail.com/

Is there anything more left form my side for this patch as you have given the
reviewed by tag to it but still it hasn't been applied yet 


> Best regards,
> Krzysztof

Regards,
Karan.

Re: [PATCH v4] dt-bindings: power: Convert raspberrypi,bcm2835-power to Dt schema

[Krzysztof Kozlowski]

On 27/11/2024 19:38, Karan Sanghavi wrote:
> On Sun, Nov 24, 2024 at 11:52:35AM +0100, Krzysztof Kozlowski wrote:
>> On 24/11/2024 09:49, Karan Sanghavi wrote:
>>> On Tue, Oct 29, 2024 at 08:10:23AM +0100, Krzysztof Kozlowski wrote:
>>>> On Mon, Oct 28, 2024 at 04:44:12PM +0000, Karan Sanghavi wrote:
>>>>> Convert the raspberrypi,bcm2835-power binding to Dt schema
>>>>>
>>>>> Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
>>>>> ---
>>>>> Changes in v4:
>>>>> - Corrected misindentations and random differences.
>>>>> - Link to v3: https://lore.kernel.org/r/20241026-raspberrypi-bcm2835-power-v3-1-6621e075d33f@gmail.com
>>>>
>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>
>>>> ---
>>>>
>>>> <form letter>
>>>> This is an automated instruction, just in case, because many review tags
>>>> are being ignored. If you know the process, you can skip it (please do
>>>> not feel offended by me posting it here - no bad intentions intended).
>>>> If you do not know the process, here is a short explanation:
>>>>
>>>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
>>>> versions, under or above your Signed-off-by tag. Tag is "received", when
>>>> provided in a message replied to you on the mailing list. Tools like b4
>>>> can help here. However, there's no need to repost patches *only* to add
>>>> the tags. The upstream maintainer will do that for tags received on the
>>>> version they apply.
>>>>
>>>> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
>>>> </form letter>
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
>>>
>>> Dear Krzysztof,
>>>
>>> I hope this email finds you well. 
>>> I'm following up on the patch I recently submitted linked below.
>>> https://lore.kernel.org/all/ZxEm-H-PjlQyXeOH@Emma/
>> I don't understand why do you reply to this patch about other patch.
>> Anyway, you got reply there.
>>
> Really sorry to attach the wrong link 
> Please find the corret link below
> https://lore.kernel.org/all/20241028-raspberrypi-bcm2835-power-v4-1-acf44abd45ff@gmail.com/
> 
> Is there anything more left form my side for this patch as you have given the
> reviewed by tag to it but still it hasn't been applied yet 

Yeah... Two things here:
1. It was not sent to PM domain maintainers, so subsystem maintainers
won't pick it up.
2. If you want to ping someone, then rather ping Broadcom maintainers,
not me. Broadcom maintainers could have taken this patch almost month ago.


For the (1) above, get_maintainers.pl is not accurate in this case. You
will get *additional* addresses to Cc with get_maintainers.pl on
drivers/pmdomain/bcm/raspberrypi-power.c. After merge window, I suggest
to resend this wider audience with *the Rb tag applied*.


Best regards,
Krzysztof