* [PATCH] drm/msm/dpu: check for null return of devm_kzalloc() in dpu_writeback_init()
@ 2022-11-19 5:55 Hui Tang
2022-12-13 21:41 ` Abhinav Kumar
2023-01-09 22:41 ` Dmitry Baryshkov
0 siblings, 2 replies; 4+ messages in thread
From: Hui Tang @ 2022-11-19 5:55 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, airlied, daniel
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, yusongping
Because of the possilble failure of devm_kzalloc(), dpu_wb_conn might
be NULL and will cause null pointer derefrence later.
Therefore, it might be better to check it and directly return -ENOMEM.
Fixes: 77b001acdcfe ("drm/msm/dpu: add the writeback connector layer")
Signed-off-by: Hui Tang <tanghui20@huawei.com>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c
index 088ec990a2f2..2a5a68366582 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c
@@ -70,6 +70,8 @@ int dpu_writeback_init(struct drm_device *dev, struct drm_encoder *enc,
int rc = 0;
dpu_wb_conn = devm_kzalloc(dev->dev, sizeof(*dpu_wb_conn), GFP_KERNEL);
+ if (!dpu_wb_conn)
+ return -ENOMEM;
drm_connector_helper_add(&dpu_wb_conn->base.base, &dpu_wb_conn_helper_funcs);
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/msm/dpu: check for null return of devm_kzalloc() in dpu_writeback_init()
2022-11-19 5:55 [PATCH] drm/msm/dpu: check for null return of devm_kzalloc() in dpu_writeback_init() Hui Tang
@ 2022-12-13 21:41 ` Abhinav Kumar
2023-01-09 22:41 ` Dmitry Baryshkov
1 sibling, 0 replies; 4+ messages in thread
From: Abhinav Kumar @ 2022-12-13 21:41 UTC (permalink / raw)
To: Hui Tang, robdclark, dmitry.baryshkov, airlied, daniel
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, yusongping
On 11/18/2022 9:55 PM, Hui Tang wrote:
> Because of the possilble failure of devm_kzalloc(), dpu_wb_conn might
> be NULL and will cause null pointer derefrence later.
derefrence --> dereference
>
> Therefore, it might be better to check it and directly return -ENOMEM.
>
> Fixes: 77b001acdcfe ("drm/msm/dpu: add the writeback connector layer")
> Signed-off-by: Hui Tang <tanghui20@huawei.com>
With that nit fixed,
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c
> index 088ec990a2f2..2a5a68366582 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c
> @@ -70,6 +70,8 @@ int dpu_writeback_init(struct drm_device *dev, struct drm_encoder *enc,
> int rc = 0;
>
> dpu_wb_conn = devm_kzalloc(dev->dev, sizeof(*dpu_wb_conn), GFP_KERNEL);
> + if (!dpu_wb_conn)
> + return -ENOMEM;
>
> drm_connector_helper_add(&dpu_wb_conn->base.base, &dpu_wb_conn_helper_funcs);
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/msm/dpu: check for null return of devm_kzalloc() in dpu_writeback_init()
2022-11-19 5:55 [PATCH] drm/msm/dpu: check for null return of devm_kzalloc() in dpu_writeback_init() Hui Tang
2022-12-13 21:41 ` Abhinav Kumar
@ 2023-01-09 22:41 ` Dmitry Baryshkov
2023-01-09 23:43 ` Dmitry Baryshkov
1 sibling, 1 reply; 4+ messages in thread
From: Dmitry Baryshkov @ 2023-01-09 22:41 UTC (permalink / raw)
To: robdclark, quic_abhinavk, airlied, daniel, Hui Tang
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, yusongping
On Sat, 19 Nov 2022 13:55:18 +0800, Hui Tang wrote:
> Because of the possilble failure of devm_kzalloc(), dpu_wb_conn might
> be NULL and will cause null pointer derefrence later.
>
> Therefore, it might be better to check it and directly return -ENOMEM.
>
>
Applied, thanks!
[1/1] drm/msm/dpu: check for null return of devm_kzalloc() in dpu_writeback_init()
https://gitlab.freedesktop.org/lumag/msm/-/commit/21e9a838f505
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/msm/dpu: check for null return of devm_kzalloc() in dpu_writeback_init()
2023-01-09 22:41 ` Dmitry Baryshkov
@ 2023-01-09 23:43 ` Dmitry Baryshkov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2023-01-09 23:43 UTC (permalink / raw)
To: robdclark, quic_abhinavk, airlied, daniel, Hui Tang
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, yusongping
On Sat, 19 Nov 2022 13:55:18 +0800, Hui Tang wrote:
> Because of the possilble failure of devm_kzalloc(), dpu_wb_conn might
> be NULL and will cause null pointer derefrence later.
>
> Therefore, it might be better to check it and directly return -ENOMEM.
>
>
Applied, thanks!
[1/1] drm/msm/dpu: check for null return of devm_kzalloc() in dpu_writeback_init()
https://gitlab.freedesktop.org/lumag/msm/-/commit/21e9a838f505
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-09 23:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-19 5:55 [PATCH] drm/msm/dpu: check for null return of devm_kzalloc() in dpu_writeback_init() Hui Tang
2022-12-13 21:41 ` Abhinav Kumar
2023-01-09 22:41 ` Dmitry Baryshkov
2023-01-09 23:43 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®