From: Tyler Baicar <tbaicar@codeaurora.org>
To: Borislav Petkov <bp@suse.de>
Cc: rjw@rjwysocki.net, tony.luck@intel.com, will.deacon@arm.com,
james.morse@arm.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 2/2] acpi: apei: call into AER handling regardless of severity
Date: Thu, 9 Nov 2017 09:37:45 -0500 [thread overview]
Message-ID: <2ec14466-bc71-3edd-7342-7cea1d754fb5@codeaurora.org> (raw)
In-Reply-To: <20171109094654.daymsvizctfrypbo@pd.tnic>
On 11/9/2017 4:46 AM, Borislav Petkov wrote:
> On Wed, Nov 08, 2017 at 12:13:12PM -0700, Tyler Baicar wrote:
>> Currently the GHES code only calls into the AER driver for
>> recoverable type errors. This is incorrect because errors of
>> other severities do not get logged by the AER driver and do not
>> get exposed to user space via the AER trace event. So, call
>> into the AER driver for PCIe errors regardless of the severity
>>
>> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>
>> ---
>> drivers/acpi/apei/ghes.c | 8 +++-----
>> 1 file changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
>> index 839c3d5..bb65fa6 100644
>> --- a/drivers/acpi/apei/ghes.c
>> +++ b/drivers/acpi/apei/ghes.c
>> @@ -458,14 +458,12 @@ static void ghes_handle_memory_failure(struct acpi_hest_generic_data *gdata, int
>> #endif
>> }
> Where did the explanatory comment go?
Ah, forgot to but that back in. I'll send an update shortly.
Thanks,
Tyler
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-11-09 14:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 19:13 [PATCH 0/2] Restructure and fix GHES PCIe AER handling Tyler Baicar
2017-11-08 19:13 ` [PATCH 1/2] acpi: apei: handle PCIe AER errors in separate function Tyler Baicar
2017-11-09 17:21 ` Borislav Petkov
2017-11-08 19:13 ` [PATCH V3 2/2] acpi: apei: call into AER handling regardless of severity Tyler Baicar
2017-11-09 9:46 ` Borislav Petkov
2017-11-09 14:37 ` Tyler Baicar [this message]
2017-11-09 15:01 ` Borislav Petkov
2017-11-09 15:14 ` Tyler Baicar
2017-11-09 17:29 ` Borislav Petkov
2017-11-13 12:36 ` Dongdong Liu
2017-11-13 15:34 ` Tyler Baicar
2017-11-15 15:14 Tyler Baicar
2017-11-18 14:54 ` Rafael J. Wysocki
2017-11-28 10:57 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ec14466-bc71-3edd-7342-7cea1d754fb5@codeaurora.org \
--to=tbaicar@codeaurora.org \
--cc=bp@suse.de \
--cc=james.morse@arm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome