mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Liu Changjie <liucj1228@outlook.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Luo Jie <jie.luo@oss.qualcomm.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/2] net: phy: Add Maxio MAE0621A support
Date: Thu, 24 Sep 2026 00:49:42 +0200	[thread overview]
Message-ID: <2ecfaee1-921b-4d2a-bac3-ce2467b24ea7@lunn.ch> (raw)
In-Reply-To: <2635661d-4be2-4abf-84aa-c3024941f787@arm.com>

> https://www.lcsc.com/datasheet/C49308069.pdf

Cool, thanks for the link.

24.13 1: A broadcast from MAC (A command with PHY address = 0) is
valid. MDC/MDIO will respond to this command.

Please ensure this is disabled. Doing that now before anything is
merged will make life easier in the future.

I don't see any way to control the RGMII delays, or know how it has
been strapped. So this PHY is going to be a real problem. DT
developers make a mess of RGMII delays even when the MAC and PHY do
the right think.

Unless a way is found to either control the delays, or at least know
what it is doing, the only phydev->interface accepted should be
PHY_INTERFACE_MODE_NA. This means 'don't touch'. We have to assume
something else has correctly set the delays in a consistent way. That
is likely to be strapping.

	  Andrew

      reply	other threads:[~2026-09-23 22:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17  3:39 Liu Changjie
2026-07-17  3:44 ` [PATCH net-next v2 2/2] net: phy: Add support for the Maxio MAE0621A Liu Changjie
2026-07-17 15:15   ` Andrew Lunn
2026-09-23 22:30   ` Andrew Lunn
2026-07-17  3:44 ` [PATCH net-next v2 1/2] dt-bindings: net: Add Maxio MAE0621A PHY Liu Changjie
2026-07-17  9:05   ` Krzysztof Kozlowski
2026-07-17  9:26     ` Liu Changjie
2026-07-19  6:04   ` Krzysztof Kozlowski
2026-08-03 13:31 ` [PATCH net-next v2 0/2] net: phy: Add Maxio MAE0621A support Andre Przywara
2026-09-23 22:49   ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ecfaee1-921b-4d2a-bac3-ce2467b24ea7@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andre.przywara@arm.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=jie.luo@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=liucj1228@outlook.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®