mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Guenter Roeck <linux@roeck-us.net>,
	Sebastian Reichel <sre@kernel.org>,
	Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
Cc: hansg@kernel.org, ilpo.jarvinen@linux.intel.com,
	andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	bryan.odonoghue@linaro.org, platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 1/3] drivers/platform: lenovo-t14s-ec: Add hwmon support for temperatures and fan speed
Date: Mon, 29 Jun 2026 10:26:52 +0200	[thread overview]
Message-ID: <2efc0f6b-3dd6-4267-b587-88c638f02be6@oss.qualcomm.com> (raw)
In-Reply-To: <faebd355-a9f4-4360-b123-87103ac512e8@roeck-us.net>

On 6/28/26 4:02 PM, Guenter Roeck wrote:
> On 6/28/26 06:50, Sebastian Reichel wrote:
>> Hi,
>>
>> On Wed, Jun 24, 2026 at 11:08:23PM +0200, Daniel Lezcano wrote:
>>> Expose the Lenovo ThinkPad T14s EC environmental sensors through
>>> the hwmon subsystem.
>>>
>>> The driver now registers a hwmon device providing access to six EC
>>> temperature sensors corresponding to the SoC, keyboard area, base
>>> cover, PMIC/charging circuitry, QTM module and SSD. Sensor labels
>>> are exported to allow user space to identify each measurement.
>>>
>>> Additionally, expose the system fan speed by reading the fan RPM
>>> registers from the embedded controller.
>>>
>>> This allows standard monitoring tools such as lm-sensors to report
>>> platform temperatures and fan speed.
>>>
>>> Signed-off-by: Daniel Lezcano daniel.lezcano@oss.qualcomm.com
>>> ---
>>
>> I gave this a try and for me the fan data is always 65535 (i.e. -1):
>>
>> $ cat /sys/class/hwmon/hwmon66/{name,fan1_input}
>> t14s_ec
>> 65535
>>
>> This is with the fan running:
>>
>> $ cat /sys/class/hwmon/hwmon57/{name,fan1_input}
>> fan-controller
>> 2564
>>
> 
> Not really my concern, but those names really add zero value,
> and I would argue that they do not "allow user space to identify
> each measurement".
> 
> Also, do you really have 66 hwmon devices on those systems ?
> Seems unusual.

There's a couple dozen thermal sensors on the SoC and each one is
registered with a thermal zone, plus a couple here and there for
other onboard peripherals (PMICs and whatnot)

Konrad

  reply	other threads:[~2026-06-29  8:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-24 21:08 [PATCH v1 0/3] Lenovo ThinkPad T14s EC thermal monitoring and thermal zone integration Daniel Lezcano
2026-06-24 21:08 ` [PATCH v1 1/3] drivers/platform: lenovo-t14s-ec: Add hwmon support for temperatures and fan speed Daniel Lezcano
2026-06-25  8:03   ` Konrad Dybcio
2026-06-25  8:06     ` Daniel Lezcano
2026-06-28 13:50   ` Sebastian Reichel
2026-06-28 14:02     ` Guenter Roeck
2026-06-29  8:26       ` Konrad Dybcio [this message]
2026-06-29  8:50         ` Daniel Lezcano
2026-06-28 17:31     ` Daniel Lezcano
2026-06-24 21:08 ` [PATCH v1 2/3] platform: arm64: thinkpad-t14s-ec: Wire EC thermal events to hwmon Daniel Lezcano
2026-06-24 21:08 ` [PATCH v1 3/3] arm64: dts: qcom: x1e78100-t14s: Add thermal zones for keyboard skin and charging sensors Daniel Lezcano
2026-06-25 11:36   ` Konrad Dybcio
2026-06-25 13:20     ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2efc0f6b-3dd6-4267-b587-88c638f02be6@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@oss.qualcomm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®