From: "KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>
To: "MinChan Kim" <minchan.kim@gmail.com>
Cc: "Mel Gorman" <mel@csn.ul.ie>, LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Nick Piggin" <npiggin@suse.de>,
"wassim dagash" <wassim.dagash@gmail.com>
Subject: Re: [PATCH] mm: stop kswapd's infinite loop at high order allocation take2
Date: Fri, 2 Jan 2009 19:00:41 +0900 [thread overview]
Message-ID: <2f11576a0901020200t3a6dadf5qa944432cd9fd8873@mail.gmail.com> (raw)
In-Reply-To: <28c262360901020155l3a9260b5h3c79d4b23a213825@mail.gmail.com>
> Hi, kosaki-san.
>
> I read the previous threads now. It's rather late :(.
>
> I think it's rather awkward that sudden big change of order from 10 to 0.
>
> This problem causes zone_water_mark's fail.
> It mean now this zone's proportional free page per order size is not good.
> Although order-0 page is very important, Shouldn't we consider other
> order allocations ?
>
> So I want to balance zone's proportional free page.
> How about following ?
>
> if (nr_reclaimed < SWAP_CLUSTER_MAX) {
> if (order != 0) {
> order -=1;
> sc.order -=1;
> }
> }
>
> It prevents infinite loop and do best effort to make zone's
> proportional free page per order size good.
>
> It's just my opinion within my knowledge.
> If it have a problem, pz, explain me :)
Please read Nick's expalin. it explain very kindly :)
next prev parent reply other threads:[~2009-01-02 10:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-30 10:55 [PATCH] mm: stop kswapd's infinite loop at high order allocation KOSAKI Motohiro
2008-12-30 11:10 ` Nick Piggin
2008-12-30 18:59 ` Mel Gorman
2008-12-31 1:32 ` Nick Piggin
2008-12-31 11:06 ` Mel Gorman
2008-12-31 11:16 ` Nick Piggin
2008-12-31 12:11 ` Mel Gorman
2008-12-31 4:54 ` KOSAKI Motohiro
2008-12-31 8:59 ` wassim dagash
2008-12-31 12:05 ` Mel Gorman
2008-12-31 12:24 ` wassim dagash
2008-12-31 11:53 ` Mel Gorman
2008-12-31 13:34 ` KOSAKI Motohiro
2009-01-01 14:52 ` [PATCH] mm: stop kswapd's infinite loop at high order allocation take2 KOSAKI Motohiro
2009-01-02 9:55 ` MinChan Kim
2009-01-02 10:00 ` KOSAKI Motohiro [this message]
2009-01-02 10:29 ` MinChan Kim
2009-01-02 10:54 ` KOSAKI Motohiro
2009-01-02 11:18 ` MinChan Kim
2009-01-02 11:14 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f11576a0901020200t3a6dadf5qa944432cd9fd8873@mail.gmail.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=npiggin@suse.de \
--cc=wassim.dagash@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®