From: Joao Pinto <Joao.Pinto@synopsys.com>
To: linux-kernel@vger.kernel.org
Cc: ijc+devicetree@hellion.org.uk, rmk+kernel@armlinux.org.uk,
linux@armlinux.org.uk, liviu.dudau@arm.com,
ryan.harkin@linaro.org, Joao Pinto <Joao.Pinto@synopsys.com>
Subject: [PATCH 3/3] tda998x: add HPD delay to avoid disabling sound when EDID checksum fails.
Date: Mon, 30 May 2016 16:15:54 +0100 [thread overview]
Message-ID: <2f242f545c99fc604fb70eeffcfd5d7703ace18d.1464619185.git.jpinto@synopsys.com> (raw)
In-Reply-To: <cover.1464619185.git.jpinto@synopsys.com>
In-Reply-To: <cover.1464619185.git.jpinto@synopsys.com>
When using ffplay to reproduce video+sound it was noticed that sometimes the
sound was disabled. The cause was an initial EDID checksum error that disabled
the HDMI sound. By adding this tweak, it was noticed that the sound is not
even when initial EDID checksum error ocurres.
Signed-off-by: Joao Pinto <jpinto@synopsys.com>
---
drivers/gpu/drm/i2c/tda998x_drv.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index 7020b50..fc7c1c3 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -587,6 +587,17 @@ static void tda998x_detect_work(struct work_struct *work)
drm_kms_helper_hotplug_event(dev);
}
+/* handle HDMI connect/disconnect */
+static void tda998x_hpd(struct work_struct *work)
+{
+ struct delayed_work *dwork = to_delayed_work(work);
+ struct tda998x_priv *priv =
+ container_of(dwork, struct tda998x_priv, dwork);
+
+ if (&priv->encoder && priv->encoder.dev)
+ drm_kms_helper_hotplug_event(priv->encoder.dev);
+}
+
/*
* only 2 interrupts may occur: screen plug/unplug and EDID read
*/
@@ -1313,6 +1324,7 @@ static int tda998x_create(struct i2c_client *client, struct tda998x_priv *priv)
/* init read EDID waitqueue and HDP work */
init_waitqueue_head(&priv->wq_edid);
+ INIT_DELAYED_WORK(&priv->dwork, tda998x_hpd);
/* clear pending interrupts */
reg_read(priv, REG_INT_FLAGS_0);
--
1.8.1.5
next prev parent reply other threads:[~2016-05-30 15:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 15:15 [PATCH 0/3] tda998x: add sound support Joao Pinto
2016-05-30 15:15 ` [PATCH 1/3] tda998x: adding " Joao Pinto
2016-05-30 15:15 ` [PATCH 2/3] tda998x: adding sound support for Juno in the DT Joao Pinto
2016-05-30 15:15 ` Joao Pinto [this message]
2016-05-30 19:10 ` [PATCH 3/3] tda998x: add HPD delay to avoid disabling sound when EDID checksum fails Russell King - ARM Linux
2016-05-31 16:58 ` Joao Pinto
2016-06-01 16:32 ` Russell King - ARM Linux
2016-06-01 16:38 ` Joao Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f242f545c99fc604fb70eeffcfd5d7703ace18d.1464619185.git.jpinto@synopsys.com \
--to=joao.pinto@synopsys.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=liviu.dudau@arm.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=ryan.harkin@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®