From: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>,
Venkat Rao Bagalkote <venkat88@linux.ibm.com>,
linux-kernel@vger.kernel.org, chleroy@kernel.org,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Shrikanth Hegde <sshegde@linux.ibm.com>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Subject: [PATCHv3 05/19] powerpc/mm/book3s64: Annotate the subpage-protection PTE lock
Date: Fri, 20 Nov 2026 09:33:04 +0530 [thread overview]
Message-ID: <2f7b796319697323ba44241bef7d5a979213b79d.1795147055.git.ritesh.list@gmail.com> (raw)
In-Reply-To: <cover.1795147055.git.ritesh.list@gmail.com>
Clang's context analysis reports:
subpage_prot.c:83:2: error: releasing spinlock 'ptl' that was not held [-Werror,-Wthread-safety-analysis]
pte_offset_map_lock() holds ptl when it returns a PTE and
pte_unmap_unlock() drops it. However since the lock is taken inside the
helper, which is not annotated, so the unlock in hpte_flush_range()
looks unheld.
This patch fixes it in hpte_flush_range() by adding the needed
annotation here. IMO, should ideally be added to pte_offset_map_lock(),
once that happens (since it might need larger enablement), we can remove
it from here.
Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
---
arch/powerpc/mm/book3s64/subpage_prot.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/mm/book3s64/subpage_prot.c b/arch/powerpc/mm/book3s64/subpage_prot.c
index 37d47282c368..d641c35c408d 100644
--- a/arch/powerpc/mm/book3s64/subpage_prot.c
+++ b/arch/powerpc/mm/book3s64/subpage_prot.c
@@ -73,6 +73,8 @@ static void hpte_flush_range(struct mm_struct *mm, unsigned long addr,
pte = pte_offset_map_lock(mm, pmd, addr, &ptl);
if (!pte)
return;
+ /* pte_offset_map_lock on success returns with ptl lock held */
+ __acquire(ptl);
lazy_mmu_mode_enable();
for (; npages > 0; --npages) {
pte_update(mm, addr, pte, 0, 0, 0);
--
2.39.5
next prev parent reply other threads:[~2026-11-20 4:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 4:02 [PATCHv3 00/19] powerpc/mm, pseries, powernv: Enable clang context analysis Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 01/19] powerpc/mm/book3s64: unlock RCU before returning from mm_iommu_is_devmem() Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 02/19] powerpc/mm/book3s64: Rework tlbie() to remove conditional locking Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 03/19] powerpc/64s/hash: Reference all arguments in the 4K pte_iterate_hashed_subpages() Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 04/19] powerpc/mm/book3s64: Rework native_flush_hash_range() to remove conditional locking Ritesh Harjani (IBM)
2026-11-20 4:03 ` Ritesh Harjani (IBM) [this message]
2026-11-20 4:03 ` [PATCHv3 06/19] powerpc/mm: Rework nohash TLB broadcast locking Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 07/19] powerpc/mm: Enable context analysis Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 08/19] powerpc/pseries: Drop inline from hugepage invalidate Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 09/19] powerpc/pseries: Rework hugepage invalidate to remove conditional locking Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 10/19] powerpc/pseries: Rework hash flush " Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 11/19] powerpc/pseries: Add context annotations for the DTL worker lock Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 12/19] powerpc/pseries: Annotate the VPD sequence lock context Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 13/19] powerpc/pseries: Annotate the RTAS indices " Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 14/19] powerpc/pseries: Annotate the RTAS physical-attestation " Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 15/19] powerpc/pseries: Annotate the DTL debugfs read " Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 16/19] powerpc/pseries: Disable context analysis for the CMM hotplug notifier Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 17/19] powerpc/pseries: Enable context analysis Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 18/19] powerpc/powernv: Rework OPAL console write to remove conditional locking Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 19/19] powerpc/powernv: Enable context analysis Ritesh Harjani (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f7b796319697323ba44241bef7d5a979213b79d.1795147055.git.ritesh.list@gmail.com \
--to=ritesh.list@gmail.com \
--cc=chleroy@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=sshegde@linux.ibm.com \
--cc=venkat88@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®