From: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>,
Venkat Rao Bagalkote <venkat88@linux.ibm.com>,
linux-kernel@vger.kernel.org, chleroy@kernel.org,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Shrikanth Hegde <sshegde@linux.ibm.com>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Subject: [PATCHv3 11/19] powerpc/pseries: Add context annotations for the DTL worker lock
Date: Fri, 20 Nov 2026 09:33:10 +0530 [thread overview]
Message-ID: <b358842b6682ac165275a75541123df3d6567bf9.1795147055.git.ritesh.list@gmail.com> (raw)
In-Reply-To: <cover.1795147055.git.ritesh.list@gmail.com>
dtl_worker_{enable,disable}() needs annotations since they acquire and
release locks. So this adds conditional annotation based on return value.
Let's also disable context analysis for vcpudispatch_stats_write(),
since based on received input, it can leave the lock held until a later
write of 0 unlocks it. So we need to mark it with __context_unsafe().
Otherwise we get following error on enabling CONTEXT_ANALYSIS on this
file:
lpar.c:490:9: error: rw_semaphore 'dtl_access_lock' is not held on every path through here [-Werror,-Wthread-safety-analysis]
lpar.c:498:2: error: releasing rw_semaphore 'dtl_access_lock' that was not held [-Werror,-Wthread-safety-analysis]
Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
---
arch/powerpc/platforms/pseries/lpar.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/powerpc/platforms/pseries/lpar.c b/arch/powerpc/platforms/pseries/lpar.c
index 5dbf447d3a83..9965ead1e93c 100644
--- a/arch/powerpc/platforms/pseries/lpar.c
+++ b/arch/powerpc/platforms/pseries/lpar.c
@@ -461,6 +461,7 @@ static void reset_global_dtl_mask(void)
}
static int dtl_worker_enable(unsigned long *time_limit)
+ __cond_acquires(0, &dtl_access_lock)
{
int rc = 0, state;
@@ -491,6 +492,7 @@ static int dtl_worker_enable(unsigned long *time_limit)
}
static void dtl_worker_disable(unsigned long *time_limit)
+ __releases(&dtl_access_lock)
{
cpuhp_remove_state(dtl_worker_state);
free_dtl_buffers(time_limit);
@@ -500,6 +502,7 @@ static void dtl_worker_disable(unsigned long *time_limit)
static ssize_t vcpudispatch_stats_write(struct file *file, const char __user *p,
size_t count, loff_t *ppos)
+ __context_unsafe(/* dtl_access_lock is held from enable write until disable write */)
{
unsigned long time_limit = jiffies + HZ;
struct vcpu_dispatch_data *disp;
--
2.39.5
next prev parent reply other threads:[~2026-11-20 4:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 4:02 [PATCHv3 00/19] powerpc/mm, pseries, powernv: Enable clang context analysis Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 01/19] powerpc/mm/book3s64: unlock RCU before returning from mm_iommu_is_devmem() Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 02/19] powerpc/mm/book3s64: Rework tlbie() to remove conditional locking Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 03/19] powerpc/64s/hash: Reference all arguments in the 4K pte_iterate_hashed_subpages() Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 04/19] powerpc/mm/book3s64: Rework native_flush_hash_range() to remove conditional locking Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 05/19] powerpc/mm/book3s64: Annotate the subpage-protection PTE lock Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 06/19] powerpc/mm: Rework nohash TLB broadcast locking Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 07/19] powerpc/mm: Enable context analysis Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 08/19] powerpc/pseries: Drop inline from hugepage invalidate Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 09/19] powerpc/pseries: Rework hugepage invalidate to remove conditional locking Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 10/19] powerpc/pseries: Rework hash flush " Ritesh Harjani (IBM)
2026-11-20 4:03 ` Ritesh Harjani (IBM) [this message]
2026-11-20 4:03 ` [PATCHv3 12/19] powerpc/pseries: Annotate the VPD sequence lock context Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 13/19] powerpc/pseries: Annotate the RTAS indices " Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 14/19] powerpc/pseries: Annotate the RTAS physical-attestation " Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 15/19] powerpc/pseries: Annotate the DTL debugfs read " Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 16/19] powerpc/pseries: Disable context analysis for the CMM hotplug notifier Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 17/19] powerpc/pseries: Enable context analysis Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 18/19] powerpc/powernv: Rework OPAL console write to remove conditional locking Ritesh Harjani (IBM)
2026-11-20 4:03 ` [PATCHv3 19/19] powerpc/powernv: Enable context analysis Ritesh Harjani (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b358842b6682ac165275a75541123df3d6567bf9.1795147055.git.ritesh.list@gmail.com \
--to=ritesh.list@gmail.com \
--cc=chleroy@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=sshegde@linux.ibm.com \
--cc=venkat88@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®