From: Sekhar Nori <nsekhar@ti.com>
To: David Lechner <david@lechnology.com>,
<linux-arm-kernel@lists.infradead.org>
Cc: Kevin Hilman <khilman@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/6] ARM: davinci: clean up map_io functions
Date: Fri, 8 Dec 2017 21:08:13 +0530 [thread overview]
Message-ID: <2f847539-0425-5d26-a48c-537ed32940ca@ti.com> (raw)
In-Reply-To: <1512182054-17410-2-git-send-email-david@lechnology.com>
On Saturday 02 December 2017 08:04 AM, David Lechner wrote:
> static int dm355leopard_mmc_get_cd(int module)
> {
> if (!gpio_is_valid(leopard_mmc_gpio))
> @@ -269,7 +264,7 @@ static __init void dm355_leopard_init(void)
>
> MACHINE_START(DM355_LEOPARD, "DaVinci DM355 leopard")
> .atag_offset = 0x100,
> - .map_io = dm355_leopard_map_io,
> + .map_io = dm355_map_io,
> .init_irq = davinci_irq_init,
> .init_time = davinci_timer_init,
> .init_machine = dm355_leopard_init,
It seems like spaces were used in original code for indentation. Can you
please introduce a patch to fix that first since you are now touching
this part of the code?
Thanks,
Sekhar
next prev parent reply other threads:[~2017-12-08 15:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-02 2:34 [PATCH v1 0/6] ARM: davinci: convert to common clock framework David Lechner
2017-12-02 2:34 ` [PATCH v1 1/6] ARM: davinci: clean up map_io functions David Lechner
2017-12-07 14:52 ` Sekhar Nori
2017-12-07 17:14 ` David Lechner
2017-12-08 15:34 ` Sekhar Nori
2017-12-08 19:14 ` David Lechner
2017-12-08 15:38 ` Sekhar Nori [this message]
2017-12-08 19:11 ` David Lechner
2017-12-02 2:34 ` [PATCH v1 2/6] ARM: davinci: move davinci_clk_init() to init_time David Lechner
2017-12-02 2:34 ` [PATCH v1 3/6] ARM: davinci: don't use static clk_lookup David Lechner
2017-12-02 2:34 ` [PATCH v1 4/6] ARM: davinci: make davinci_clk_reset() static David Lechner
2017-12-02 2:34 ` [PATCH v1 5/6] ARM: davinci: convert to common clock framework David Lechner
2017-12-02 2:34 ` [PATCH v1 6/6] ARM: davinci: remove clock debugfs David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f847539-0425-5d26-a48c-537ed32940ca@ti.com \
--to=nsekhar@ti.com \
--cc=david@lechnology.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®