From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Aubrey Li <aubrey.li@linux.intel.com>,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
linux-pm@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] thermal: intel: INTEL_HFI_THERMAL depends on NET
Date: Tue, 08 Feb 2022 17:20:55 -0800 [thread overview]
Message-ID: <2f8915fd15862a70ed5c4b92632bbe6035b8ea57.camel@linux.intel.com> (raw)
In-Reply-To: <20220209001546.18189-1-rdunlap@infradead.org>
On Tue, 2022-02-08 at 16:15 -0800, Randy Dunlap wrote:
> THERMAL_NETLINK depends on NET and since 'select' does not follow
> any dependency chain, INTEL_HFI_THERMAL also should depend on NET.
>
> Fix one Kconfig warning and 48 subsequent build errors:
>
> WARNING: unmet direct dependencies detected for THERMAL_NETLINK
> Depends on [n]: THERMAL [=y] && NET [=n]
> Selected by [y]:
> - INTEL_HFI_THERMAL [=y] && THERMAL [=y] && (X86 [=y] ||
> X86_INTEL_QUARK [=n] || COMPILE_TEST [=y]) && CPU_SUP_INTEL [=y] &&
> X86_THERMAL_VECTOR [=y]
>
Thanks for the fix.
> Fixes: bd30cdfd9bd7 ("thermal: intel: hfi: Notify user space for HFI
> events")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Aubrey Li <aubrey.li@linux.intel.com>
> Cc: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
> Cc: Rafael J. Wysocki <rafael@kernel.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Amit Kucheria <amitk@kernel.org>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: linux-pm@vger.kernel.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> Found in mmotm, linux-next.patch.
>
> drivers/thermal/intel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- mmotm-2022-0208-1531.orig/drivers/thermal/intel/Kconfig
> +++ mmotm-2022-0208-1531/drivers/thermal/intel/Kconfig
> @@ -102,6 +102,7 @@ config INTEL_MENLOW
>
> config INTEL_HFI_THERMAL
> bool "Intel Hardware Feedback Interface"
> + depends on NET
> depends on CPU_SUP_INTEL
> depends on X86_THERMAL_VECTOR
> select THERMAL_NETLINK
prev parent reply other threads:[~2022-02-09 2:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 0:15 Randy Dunlap
2022-02-09 1:20 ` srinivas pandruvada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f8915fd15862a70ed5c4b92632bbe6035b8ea57.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=amitk@kernel.org \
--cc=aubrey.li@linux.intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®