* [PATCH -next] thermal: intel: INTEL_HFI_THERMAL depends on NET
@ 2022-02-09 0:15 Randy Dunlap
2022-02-09 1:20 ` srinivas pandruvada
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2022-02-09 0:15 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Srinivas Pandruvada, Aubrey Li, Ricardo Neri,
Rafael J . Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
linux-pm, Andrew Morton
THERMAL_NETLINK depends on NET and since 'select' does not follow
any dependency chain, INTEL_HFI_THERMAL also should depend on NET.
Fix one Kconfig warning and 48 subsequent build errors:
WARNING: unmet direct dependencies detected for THERMAL_NETLINK
Depends on [n]: THERMAL [=y] && NET [=n]
Selected by [y]:
- INTEL_HFI_THERMAL [=y] && THERMAL [=y] && (X86 [=y] || X86_INTEL_QUARK [=n] || COMPILE_TEST [=y]) && CPU_SUP_INTEL [=y] && X86_THERMAL_VECTOR [=y]
Fixes: bd30cdfd9bd7 ("thermal: intel: hfi: Notify user space for HFI events")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Aubrey Li <aubrey.li@linux.intel.com>
Cc: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Amit Kucheria <amitk@kernel.org>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: linux-pm@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
---
Found in mmotm, linux-next.patch.
drivers/thermal/intel/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- mmotm-2022-0208-1531.orig/drivers/thermal/intel/Kconfig
+++ mmotm-2022-0208-1531/drivers/thermal/intel/Kconfig
@@ -102,6 +102,7 @@ config INTEL_MENLOW
config INTEL_HFI_THERMAL
bool "Intel Hardware Feedback Interface"
+ depends on NET
depends on CPU_SUP_INTEL
depends on X86_THERMAL_VECTOR
select THERMAL_NETLINK
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] thermal: intel: INTEL_HFI_THERMAL depends on NET
2022-02-09 0:15 [PATCH -next] thermal: intel: INTEL_HFI_THERMAL depends on NET Randy Dunlap
@ 2022-02-09 1:20 ` srinivas pandruvada
0 siblings, 0 replies; 2+ messages in thread
From: srinivas pandruvada @ 2022-02-09 1:20 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Aubrey Li, Ricardo Neri, Rafael J . Wysocki, Daniel Lezcano,
Amit Kucheria, Zhang Rui, linux-pm, Andrew Morton
On Tue, 2022-02-08 at 16:15 -0800, Randy Dunlap wrote:
> THERMAL_NETLINK depends on NET and since 'select' does not follow
> any dependency chain, INTEL_HFI_THERMAL also should depend on NET.
>
> Fix one Kconfig warning and 48 subsequent build errors:
>
> WARNING: unmet direct dependencies detected for THERMAL_NETLINK
> Depends on [n]: THERMAL [=y] && NET [=n]
> Selected by [y]:
> - INTEL_HFI_THERMAL [=y] && THERMAL [=y] && (X86 [=y] ||
> X86_INTEL_QUARK [=n] || COMPILE_TEST [=y]) && CPU_SUP_INTEL [=y] &&
> X86_THERMAL_VECTOR [=y]
>
Thanks for the fix.
> Fixes: bd30cdfd9bd7 ("thermal: intel: hfi: Notify user space for HFI
> events")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Aubrey Li <aubrey.li@linux.intel.com>
> Cc: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
> Cc: Rafael J. Wysocki <rafael@kernel.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Amit Kucheria <amitk@kernel.org>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: linux-pm@vger.kernel.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> Found in mmotm, linux-next.patch.
>
> drivers/thermal/intel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- mmotm-2022-0208-1531.orig/drivers/thermal/intel/Kconfig
> +++ mmotm-2022-0208-1531/drivers/thermal/intel/Kconfig
> @@ -102,6 +102,7 @@ config INTEL_MENLOW
>
> config INTEL_HFI_THERMAL
> bool "Intel Hardware Feedback Interface"
> + depends on NET
> depends on CPU_SUP_INTEL
> depends on X86_THERMAL_VECTOR
> select THERMAL_NETLINK
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-09 2:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-09 0:15 [PATCH -next] thermal: intel: INTEL_HFI_THERMAL depends on NET Randy Dunlap
2022-02-09 1:20 ` srinivas pandruvada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®