* [PATCH -next] writeback: Cleanup bdi_sched_wait()
@ 2022-07-13 12:53 Xiu Jianfeng
2022-07-13 14:03 ` Jan Kara
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Xiu Jianfeng @ 2022-07-13 12:53 UTC (permalink / raw)
To: akpm, axboe, neilb, johannes.thumshirn, jack, willy, mgorman; +Cc: linux-kernel
bdi_sched_wait() is no longer used since commit 839a8e8660b6 ("writeback:
replace custom worker pool implementation with unbound workqueue"),
so remove it.
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
---
include/linux/backing-dev.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index d452071db572..e84b745a6811 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -140,12 +140,6 @@ static inline bool mapping_can_writeback(struct address_space *mapping)
return inode_to_bdi(mapping->host)->capabilities & BDI_CAP_WRITEBACK;
}
-static inline int bdi_sched_wait(void *word)
-{
- schedule();
- return 0;
-}
-
#ifdef CONFIG_CGROUP_WRITEBACK
struct bdi_writeback *wb_get_lookup(struct backing_dev_info *bdi,
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] writeback: Cleanup bdi_sched_wait()
2022-07-13 12:53 [PATCH -next] writeback: Cleanup bdi_sched_wait() Xiu Jianfeng
@ 2022-07-13 14:03 ` Jan Kara
2022-07-13 14:05 ` Johannes Thumshirn
2022-07-13 15:58 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Jan Kara @ 2022-07-13 14:03 UTC (permalink / raw)
To: Xiu Jianfeng
Cc: akpm, axboe, neilb, johannes.thumshirn, jack, willy, mgorman,
linux-kernel
On Wed 13-07-22 20:53:14, Xiu Jianfeng wrote:
> bdi_sched_wait() is no longer used since commit 839a8e8660b6 ("writeback:
> replace custom worker pool implementation with unbound workqueue"),
> so remove it.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Nice. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> include/linux/backing-dev.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
> index d452071db572..e84b745a6811 100644
> --- a/include/linux/backing-dev.h
> +++ b/include/linux/backing-dev.h
> @@ -140,12 +140,6 @@ static inline bool mapping_can_writeback(struct address_space *mapping)
> return inode_to_bdi(mapping->host)->capabilities & BDI_CAP_WRITEBACK;
> }
>
> -static inline int bdi_sched_wait(void *word)
> -{
> - schedule();
> - return 0;
> -}
> -
> #ifdef CONFIG_CGROUP_WRITEBACK
>
> struct bdi_writeback *wb_get_lookup(struct backing_dev_info *bdi,
> --
> 2.17.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] writeback: Cleanup bdi_sched_wait()
2022-07-13 12:53 [PATCH -next] writeback: Cleanup bdi_sched_wait() Xiu Jianfeng
2022-07-13 14:03 ` Jan Kara
@ 2022-07-13 14:05 ` Johannes Thumshirn
2022-07-13 15:58 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Johannes Thumshirn @ 2022-07-13 14:05 UTC (permalink / raw)
To: Xiu Jianfeng, akpm, axboe, neilb, jack, willy, mgorman; +Cc: linux-kernel
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] writeback: Cleanup bdi_sched_wait()
2022-07-13 12:53 [PATCH -next] writeback: Cleanup bdi_sched_wait() Xiu Jianfeng
2022-07-13 14:03 ` Jan Kara
2022-07-13 14:05 ` Johannes Thumshirn
@ 2022-07-13 15:58 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2022-07-13 15:58 UTC (permalink / raw)
To: Xiu Jianfeng, akpm, neilb, johannes.thumshirn, jack, willy, mgorman
Cc: linux-kernel
On 7/13/22 6:53 AM, Xiu Jianfeng wrote:
> bdi_sched_wait() is no longer used since commit 839a8e8660b6 ("writeback:
> replace custom worker pool implementation with unbound workqueue"),
> so remove it.
Heh, 9 years later! Nice find:
Acked-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-13 15:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-13 12:53 [PATCH -next] writeback: Cleanup bdi_sched_wait() Xiu Jianfeng
2022-07-13 14:03 ` Jan Kara
2022-07-13 14:05 ` Johannes Thumshirn
2022-07-13 15:58 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®