From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
To: thor.thayer@linux.intel.com, bp@alien8.de, mchehab@kernel.org
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] EDAC, altera: Fix an error handling path in 'mv64x60_pci_err_probe()'
Date: Sun, 10 Jun 2018 18:01:12 +0200 [thread overview]
Message-ID: <2fc37391-e491-a68a-ad45-cf39cf7595d5@wanadoo.fr> (raw)
In-Reply-To: <20180610153423.10769-1-christophe.jaillet@wanadoo.fr>
Le 10/06/2018 à 17:34, Christophe JAILLET a écrit :
> IF 'regmap_write()' fails, we should release some resources as done in all
> the other error handling paths of the function.
>
> Fixes: e9918d7fafae ("EDAC, altera: Handle SDRAM Uncorrectable Errors on Stratix10")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/edac/altera_edac.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index d0d5c4dbe097..5762c3c383f2 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c
> @@ -730,7 +730,8 @@ static int altr_s10_sdram_probe(struct platform_device *pdev)
> S10_DDR0_IRQ_MASK)) {
> edac_printk(KERN_ERR, EDAC_MC,
> "Error clearing SDRAM ECC count\n");
> - return -ENODEV;
> + ret = -ENODEV;
> + goto err2;
> }
>
> if (regmap_update_bits(drvdata->mc_vbase, priv->ecc_irq_en_offset,
>
Wrong subjet, will resend a v2 for that.
WARNING: multiple messages have this Message-ID
From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
To: linux-kernel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] EDAC, altera: Fix an error handling path in 'mv64x60_pci_err_probe()'
Date: Sun, 10 Jun 2018 18:01:12 +0200 [thread overview]
Message-ID: <2fc37391-e491-a68a-ad45-cf39cf7595d5@wanadoo.fr> (raw)
Message-ID: <20180610160112.v5I4Ai-OBo68oymnQUgKLJD0x4lFst_ukuG44IF60J8@z> (raw)
In-Reply-To: <20180610153423.10769-1-christophe.jaillet@wanadoo.fr>
Le 10/06/2018 à 17:34, Christophe JAILLET a écrit :
> IF 'regmap_write()' fails, we should release some resources as done in all
> the other error handling paths of the function.
>
> Fixes: e9918d7fafae ("EDAC, altera: Handle SDRAM Uncorrectable Errors on Stratix10")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/edac/altera_edac.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index d0d5c4dbe097..5762c3c383f2 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c
> @@ -730,7 +730,8 @@ static int altr_s10_sdram_probe(struct platform_device *pdev)
> S10_DDR0_IRQ_MASK)) {
> edac_printk(KERN_ERR, EDAC_MC,
> "Error clearing SDRAM ECC count\n");
> - return -ENODEV;
> + ret = -ENODEV;
> + goto err2;
> }
>
> if (regmap_update_bits(drvdata->mc_vbase, priv->ecc_irq_en_offset,
>
Wrong subjet, will resend a v2 for that.
next prev parent reply other threads:[~2018-06-10 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-10 15:34 Christophe JAILLET
2018-06-10 16:01 ` Christophe Jaillet [this message]
2018-06-10 16:01 ` Christophe Jaillet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fc37391-e491-a68a-ad45-cf39cf7595d5@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=bp@alien8.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=thor.thayer@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®