Re: [PATCH RESEND v3 1/3] drm/stm: dsi: use new SYSTEM_SLEEP_PM_OPS() macro

[Yannick FERTRE <yannick.fertre@foss.st.com>]

Hi Raphael,

thanks for the patch.

Acked-by: Yannick Fertre <yannick.fertre@foss.st.com>

Tested-by: Yannick Fertre <yannick.fertre@foss.st.com>

BR


Le 29/01/2024 à 11:41, Raphael Gallais-Pou a écrit :
> Use RUNTIME_PM_OPS() instead of the old SET_SYSTEM_SLEEP_PM_OPS().
> This means we don't need  __maybe_unused on the functions.
>
> Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
> ---
>   drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> index d5f8c923d7bc..b1aee43d51e9 100644
> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> @@ -544,7 +544,7 @@ static void dw_mipi_dsi_stm_remove(struct platform_device *pdev)
>   	regulator_disable(dsi->vdd_supply);
>   }
>   
> -static int __maybe_unused dw_mipi_dsi_stm_suspend(struct device *dev)
> +static int dw_mipi_dsi_stm_suspend(struct device *dev)
>   {
>   	struct dw_mipi_dsi_stm *dsi = dw_mipi_dsi_stm_plat_data.priv_data;
>   
> @@ -556,7 +556,7 @@ static int __maybe_unused dw_mipi_dsi_stm_suspend(struct device *dev)
>   	return 0;
>   }
>   
> -static int __maybe_unused dw_mipi_dsi_stm_resume(struct device *dev)
> +static int dw_mipi_dsi_stm_resume(struct device *dev)
>   {
>   	struct dw_mipi_dsi_stm *dsi = dw_mipi_dsi_stm_plat_data.priv_data;
>   	int ret;
> @@ -580,8 +580,8 @@ static int __maybe_unused dw_mipi_dsi_stm_resume(struct device *dev)
>   }
>   
>   static const struct dev_pm_ops dw_mipi_dsi_stm_pm_ops = {
> -	SET_SYSTEM_SLEEP_PM_OPS(dw_mipi_dsi_stm_suspend,
> -				dw_mipi_dsi_stm_resume)
> +	SYSTEM_SLEEP_PM_OPS(dw_mipi_dsi_stm_suspend,
> +			    dw_mipi_dsi_stm_resume)
>   };
>   
>   static struct platform_driver dw_mipi_dsi_stm_driver = {