From: Ahmet Sezgin Duran <ahmet@sezginduran.net>
To: Linus Probert <linus.probert@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: rename rtw_setstaKey_cmdrsp_callback()
Date: Thu, 22 Oct 2026 15:31:32 +0300 [thread overview]
Message-ID: <2fd90a2c-a2ab-41ab-bcd1-02831b4e01ca@sezginduran.net> (raw)
In-Reply-To: <20261022122234.443631-1-linus.probert@gmail.com>
On 10/22/26 3:22 PM, Linus Probert wrote:
> Renames rtw_setstaKey_cmdrsp_callback to rtw_setstakey_cmdrsp_callback
> in order to conform to kernel code style.
>
> Found using checkpatch.pl
>
> Signed-off-by: Linus Probert <linus.probert@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 4 ++--
> drivers/staging/rtl8723bs/include/rtw_cmd.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index 9fc62cb1ae01..81aef5ffe685 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -34,7 +34,7 @@ static struct _cmd_callback rtw_cmd_callback[] = {
> {SET_AUTH_CMD, NULL},
>
> {SET_KEY_CMD, NULL}, /*20*/
> - {SET_STA_KEY_CMD, &rtw_setstaKey_cmdrsp_callback},
> + {SET_STA_KEY_CMD, &rtw_setstakey_cmdrsp_callback},
> {SET_ASSOC_STA_CMD, &rtw_setassocsta_cmdrsp_callback},
> {DEL_ASSOC_STA_CMD, NULL},
> {SET_STA_PWR_STATE_CMD, NULL},
> @@ -1876,7 +1876,7 @@ void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd)
> rtw_free_cmd_obj(pcmd);
> }
>
> -void rtw_setstaKey_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd)
> +void rtw_setstakey_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd)
> {
> struct sta_priv *pstapriv = &padapter->stapriv;
> struct set_stakey_rsp *psetstakey_rsp = (struct set_stakey_rsp *)(pcmd->rsp);
> diff --git a/drivers/staging/rtl8723bs/include/rtw_cmd.h b/drivers/staging/rtl8723bs/include/rtw_cmd.h
> index 75a774f8c4f3..9b801a61b69b 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_cmd.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_cmd.h
> @@ -593,7 +593,7 @@ void rtw_joinbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd);
> void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd);
> void rtw_getbbrfreg_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
>
> -void rtw_setstaKey_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
> +void rtw_setstakey_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
> void rtw_setassocsta_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
> void rtw_getrttbl_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
>
This driver is going to be deleted in the next release, have a look:
https://lore.kernel.org/linux-staging/7e53bd59b7b146caabebeca4347674c7@realtek.com/
Regards,
Ahmet Sezgin Duran
next prev parent reply other threads:[~2026-10-22 12:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 12:22 Linus Probert
2026-10-22 12:31 ` Ahmet Sezgin Duran [this message]
2026-10-22 12:34 ` Linus Probert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fd90a2c-a2ab-41ab-bcd1-02831b4e01ca@sezginduran.net \
--to=ahmet@sezginduran.net \
--cc=gregkh@linuxfoundation.org \
--cc=linus.probert@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®