* [PATCH] staging: rtl8723bs: rename rtw_setstaKey_cmdrsp_callback()
@ 2026-10-22 12:22 Linus Probert
2026-10-22 12:31 ` Ahmet Sezgin Duran
0 siblings, 1 reply; 3+ messages in thread
From: Linus Probert @ 2026-10-22 12:22 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Linus Probert
Renames rtw_setstaKey_cmdrsp_callback to rtw_setstakey_cmdrsp_callback
in order to conform to kernel code style.
Found using checkpatch.pl
Signed-off-by: Linus Probert <linus.probert@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 4 ++--
drivers/staging/rtl8723bs/include/rtw_cmd.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index 9fc62cb1ae01..81aef5ffe685 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -34,7 +34,7 @@ static struct _cmd_callback rtw_cmd_callback[] = {
{SET_AUTH_CMD, NULL},
{SET_KEY_CMD, NULL}, /*20*/
- {SET_STA_KEY_CMD, &rtw_setstaKey_cmdrsp_callback},
+ {SET_STA_KEY_CMD, &rtw_setstakey_cmdrsp_callback},
{SET_ASSOC_STA_CMD, &rtw_setassocsta_cmdrsp_callback},
{DEL_ASSOC_STA_CMD, NULL},
{SET_STA_PWR_STATE_CMD, NULL},
@@ -1876,7 +1876,7 @@ void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd)
rtw_free_cmd_obj(pcmd);
}
-void rtw_setstaKey_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd)
+void rtw_setstakey_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd)
{
struct sta_priv *pstapriv = &padapter->stapriv;
struct set_stakey_rsp *psetstakey_rsp = (struct set_stakey_rsp *)(pcmd->rsp);
diff --git a/drivers/staging/rtl8723bs/include/rtw_cmd.h b/drivers/staging/rtl8723bs/include/rtw_cmd.h
index 75a774f8c4f3..9b801a61b69b 100644
--- a/drivers/staging/rtl8723bs/include/rtw_cmd.h
+++ b/drivers/staging/rtl8723bs/include/rtw_cmd.h
@@ -593,7 +593,7 @@ void rtw_joinbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd);
void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd);
void rtw_getbbrfreg_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
-void rtw_setstaKey_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
+void rtw_setstakey_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
void rtw_setassocsta_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
void rtw_getrttbl_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
--
2.56.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: rename rtw_setstaKey_cmdrsp_callback()
2026-10-22 12:22 [PATCH] staging: rtl8723bs: rename rtw_setstaKey_cmdrsp_callback() Linus Probert
@ 2026-10-22 12:31 ` Ahmet Sezgin Duran
2026-10-22 12:34 ` Linus Probert
0 siblings, 1 reply; 3+ messages in thread
From: Ahmet Sezgin Duran @ 2026-10-22 12:31 UTC (permalink / raw)
To: Linus Probert, Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel
On 10/22/26 3:22 PM, Linus Probert wrote:
> Renames rtw_setstaKey_cmdrsp_callback to rtw_setstakey_cmdrsp_callback
> in order to conform to kernel code style.
>
> Found using checkpatch.pl
>
> Signed-off-by: Linus Probert <linus.probert@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 4 ++--
> drivers/staging/rtl8723bs/include/rtw_cmd.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index 9fc62cb1ae01..81aef5ffe685 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -34,7 +34,7 @@ static struct _cmd_callback rtw_cmd_callback[] = {
> {SET_AUTH_CMD, NULL},
>
> {SET_KEY_CMD, NULL}, /*20*/
> - {SET_STA_KEY_CMD, &rtw_setstaKey_cmdrsp_callback},
> + {SET_STA_KEY_CMD, &rtw_setstakey_cmdrsp_callback},
> {SET_ASSOC_STA_CMD, &rtw_setassocsta_cmdrsp_callback},
> {DEL_ASSOC_STA_CMD, NULL},
> {SET_STA_PWR_STATE_CMD, NULL},
> @@ -1876,7 +1876,7 @@ void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd)
> rtw_free_cmd_obj(pcmd);
> }
>
> -void rtw_setstaKey_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd)
> +void rtw_setstakey_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd)
> {
> struct sta_priv *pstapriv = &padapter->stapriv;
> struct set_stakey_rsp *psetstakey_rsp = (struct set_stakey_rsp *)(pcmd->rsp);
> diff --git a/drivers/staging/rtl8723bs/include/rtw_cmd.h b/drivers/staging/rtl8723bs/include/rtw_cmd.h
> index 75a774f8c4f3..9b801a61b69b 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_cmd.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_cmd.h
> @@ -593,7 +593,7 @@ void rtw_joinbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd);
> void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd);
> void rtw_getbbrfreg_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
>
> -void rtw_setstaKey_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
> +void rtw_setstakey_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
> void rtw_setassocsta_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
> void rtw_getrttbl_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
>
This driver is going to be deleted in the next release, have a look:
https://lore.kernel.org/linux-staging/7e53bd59b7b146caabebeca4347674c7@realtek.com/
Regards,
Ahmet Sezgin Duran
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: rename rtw_setstaKey_cmdrsp_callback()
2026-10-22 12:31 ` Ahmet Sezgin Duran
@ 2026-10-22 12:34 ` Linus Probert
0 siblings, 0 replies; 3+ messages in thread
From: Linus Probert @ 2026-10-22 12:34 UTC (permalink / raw)
To: Ahmet Sezgin Duran, Linus Probert, Greg Kroah-Hartman
Cc: linux-staging, linux-kernel
On Thu Oct 22, 2026 at 2:31 PM CEST, Ahmet Sezgin Duran wrote:
> On 10/22/26 3:22 PM, Linus Probert wrote:
>> Renames rtw_setstaKey_cmdrsp_callback to rtw_setstakey_cmdrsp_callback
>> in order to conform to kernel code style.
>>
>> Found using checkpatch.pl
>>
>> Signed-off-by: Linus Probert <linus.probert@gmail.com>
>> ---
>> drivers/staging/rtl8723bs/core/rtw_cmd.c | 4 ++--
>> drivers/staging/rtl8723bs/include/rtw_cmd.h | 2 +-
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
>> index 9fc62cb1ae01..81aef5ffe685 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
>> @@ -34,7 +34,7 @@ static struct _cmd_callback rtw_cmd_callback[] = {
>> {SET_AUTH_CMD, NULL},
>>
>> {SET_KEY_CMD, NULL}, /*20*/
>> - {SET_STA_KEY_CMD, &rtw_setstaKey_cmdrsp_callback},
>> + {SET_STA_KEY_CMD, &rtw_setstakey_cmdrsp_callback},
>> {SET_ASSOC_STA_CMD, &rtw_setassocsta_cmdrsp_callback},
>> {DEL_ASSOC_STA_CMD, NULL},
>> {SET_STA_PWR_STATE_CMD, NULL},
>> @@ -1876,7 +1876,7 @@ void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd)
>> rtw_free_cmd_obj(pcmd);
>> }
>>
>> -void rtw_setstaKey_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd)
>> +void rtw_setstakey_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd)
>> {
>> struct sta_priv *pstapriv = &padapter->stapriv;
>> struct set_stakey_rsp *psetstakey_rsp = (struct set_stakey_rsp *)(pcmd->rsp);
>> diff --git a/drivers/staging/rtl8723bs/include/rtw_cmd.h b/drivers/staging/rtl8723bs/include/rtw_cmd.h
>> index 75a774f8c4f3..9b801a61b69b 100644
>> --- a/drivers/staging/rtl8723bs/include/rtw_cmd.h
>> +++ b/drivers/staging/rtl8723bs/include/rtw_cmd.h
>> @@ -593,7 +593,7 @@ void rtw_joinbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd);
>> void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd);
>> void rtw_getbbrfreg_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
>>
>> -void rtw_setstaKey_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
>> +void rtw_setstakey_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
>> void rtw_setassocsta_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
>> void rtw_getrttbl_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pcmd);
>>
>
> This driver is going to be deleted in the next release, have a look:
>
> https://lore.kernel.org/linux-staging/7e53bd59b7b146caabebeca4347674c7@realtek.com/
>
> Regards,
> Ahmet Sezgin Duran
Ah, no. I had missed that apologies and thanks for the info.
// Linus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-22 12:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-22 12:22 [PATCH] staging: rtl8723bs: rename rtw_setstaKey_cmdrsp_callback() Linus Probert
2026-10-22 12:31 ` Ahmet Sezgin Duran
2026-10-22 12:34 ` Linus Probert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®