mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Tao Zhang <quic_taozha@quicinc.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Konrad Dybcio <konradybcio@gmail.com>,
	Mike Leach <mike.leach@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Jinlong Mao <quic_jinlmao@quicinc.com>,
	Leo Yan <leo.yan@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Tingwei Zhang <quic_tingweiz@quicinc.com>,
	Yuanfang Zhang <quic_yuanfang@quicinc.com>,
	Trilok Soni <quic_tsoni@quicinc.com>,
	Hao Zhang <quic_hazha@quicinc.com>,
	linux-arm-msm@vger.kernel.org, andersson@kernel.org
Subject: Re: [PATCH v9 00/13] Add support to configure TPDM DSB subunit
Date: Tue, 26 Sep 2023 14:12:10 +0100	[thread overview]
Message-ID: <2fe54425-70b5-95e8-1e9e-337424827adb@arm.com> (raw)
In-Reply-To: <1694670204-11515-1-git-send-email-quic_taozha@quicinc.com>

On 14/09/2023 06:43, Tao Zhang wrote:
> Introduction of TPDM DSB subunit
> DSB subunit is responsible for creating a dataset element, and is also
> optionally responsible for packing it to fit multiple elements on a
> single ATB transfer if possible in the configuration. The TPDM Core
> Datapath requests timestamps be stored by the TPDA and then delivering
> ATB sized data (depending on ATB width and element size, this could
> be smaller or larger than a dataset element) to the ATB Mast FSM.
> 
> The DSB subunit must be configured prior to enablement. This series
> adds support for TPDM to configure the configure DSB subunit.
> 
> Once this series patches are applied properly, the new tpdm nodes for
> should be observed at the tpdm path /sys/bus/coresight/devices/tpdm*
> which supports DSB subunit.
> e.g.
> root@qemuarm64:/sys/devices/platform/soc@0/6c08000.tpdm/tpdm1# ls -l
> drwxr-xr-x    2 root     root             0 Jan  1 00:00 connections
> drwxr-xr-x    2 root     root             0 Jan  1 00:00 dsb_edge
> -rw-r--r--    1 root     root          4096 Jan  1 00:00 dsb_mode
> drwxr-xr-x    2 root     root             0 Jan  1 00:00 dsb_msr
> drwxr-xr-x    2 root     root             0 Jan  1 00:00 dsb_patt
> -rw-r--r--    1 root     root          4096 Jan  1 00:00 dsb_patt_ts
> -rw-r--r--    1 root     root          4096 Jan  1 00:00 dsb_patt_type
> drwxr-xr-x    2 root     root             0 Jan  1 00:00 dsb_trig_patt
> -rw-r--r--    1 root     root          4096 Jan  1 00:00 dsb_trig_ts
> -rw-r--r--    1 root     root          4096 Jan  1 00:00 dsb_trig_type
> -rw-r--r--    1 root     root          4096 Jan  1 00:02 enable_source
> --w-------    1 root     root          4096 Jan  1 00:00 integration_test
> drwxr-xr-x    2 root     root             0 Jan  1 00:00 power
> --w-------    1 root     root          4096 Jan  1 00:02 reset_dataset
> lrwxrwxrwx    1 root     root             0 Apr  5  2021 subsystem -> ../../../../../bus/coresight
> -rw-r--r--    1 root     root          4096 Apr  5  2021 uevent
> -r--r--r--    1 root     root          4096 Jan  1 00:00 waiting_for_supplier
> 
> We can use the commands are similar to the below to configure the
> TPDMs which support DSB subunit. Enable coresight sink first.
> echo 1 > /sys/bus/coresight/devices/tmc_etf0/enable_sink
> echo 1 > /sys/bus/coresight/devices/tpdm1/reset_dataset
> echo 0x3 > /sys/bus/coresight/devices/tpdm1/dsb_edge/ctrl_idx
> echo 0x1 > /sys/bus/coresight/devices/tpdm1/dsb_edge/ctrl_mask
> echo 0x0 > /sys/bus/coresight/devices/tpdm1/dsb_edge/ctrl_val
> echo 1 > /sys/bus/coresight/devices/tpdm1/dsb_patt/enable_ts
> echo 1 > /sys/bus/coresight/devices/tpdm1/dsb_patt/set_type
> echo 0 > /sys/bus/coresight/devices/tpdm1/dsb_trig_ts
> echo 0xFFFFFFFF > /sys/bus/coresight/devices/tpdm1/dsb_patt/tpmr5
> echo 0xFFFFFFFF > /sys/bus/coresight/devices/tpdm1/dsb_trig_patt/xpr2
> echo 1 > /sys/bus/coresight/devices/tpdm1/enable_source
> 

I have reviewed this set, except for the last patch, rest looks fine.
If you could resend the series with the comments addressed, we could
queue this.

Suzuki

  parent reply	other threads:[~2023-09-26 13:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14  5:43 Tao Zhang
2023-09-14  5:43 ` [PATCH v9 01/13] coresight-tpdm: Remove the unnecessary lock Tao Zhang
2023-09-14  5:43 ` [PATCH v9 02/13] dt-bindings: arm: Add support for DSB element size Tao Zhang
2023-09-14  5:43 ` [PATCH v9 03/13] coresight-tpdm: Introduce TPDM subtype to TPDM driver Tao Zhang
2023-09-14  5:43 ` [PATCH v9 04/13] coresight-tpda: Add DSB dataset support Tao Zhang
2023-09-14  5:43 ` [PATCH v9 05/13] coresight-tpdm: Initialize DSB subunit configuration Tao Zhang
2023-09-14  5:43 ` [PATCH v9 06/13] coresight-tpdm: Add reset node to TPDM node Tao Zhang
2023-09-14  5:43 ` [PATCH v9 07/13] coresight-tpdm: Add nodes to set trigger timestamp and type Tao Zhang
2023-09-14  5:43 ` [PATCH v9 08/13] coresight-tpdm: Add node to set dsb programming mode Tao Zhang
2023-09-14  5:43 ` [PATCH v9 09/13] coresight-tpdm: Add nodes for dsb edge control Tao Zhang
2023-09-14  5:43 ` [PATCH v9 10/13] coresight-tpdm: Add nodes to configure pattern match output Tao Zhang
2023-09-14  5:43 ` [PATCH v9 11/13] coresight-tpdm: Add nodes for timestamp request Tao Zhang
2023-09-14  5:43 ` [PATCH v9 12/13] dt-bindings: arm: Add support for DSB MSR register Tao Zhang
2023-09-14  5:43 ` [PATCH v9 13/13] coresight-tpdm: Add nodes for dsb msr support Tao Zhang
2023-09-26 11:46   ` Suzuki K Poulose
2023-09-27  6:26     ` Tao Zhang
2023-09-26 13:12 ` Suzuki K Poulose [this message]
2023-09-27  6:37   ` [PATCH v9 00/13] Add support to configure TPDM DSB subunit Tao Zhang
2023-09-27  8:58     ` Suzuki K Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2fe54425-70b5-95e8-1e9e-337424827adb@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=andersson@kernel.org \
    --cc=coresight@lists.linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=konradybcio@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=quic_hazha@quicinc.com \
    --cc=quic_jinlmao@quicinc.com \
    --cc=quic_taozha@quicinc.com \
    --cc=quic_tingweiz@quicinc.com \
    --cc=quic_tsoni@quicinc.com \
    --cc=quic_yuanfang@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®