From: Chris Metcalf <cmetcalf@mellanox.com>
To: Christoph Lameter <cl@linux.com>
Cc: Gilad Ben Yossef <giladb@mellanox.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Rik van Riel" <riel@redhat.com>, Tejun Heo <tj@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
"Will Deacon" <will.deacon@arm.com>,
Andy Lutomirski <luto@amacapital.net>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
<linux-doc@vger.kernel.org>, <linux-api@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: clocksource_watchdog causing scheduling of timers every second (was [v13] support "task_isolation" mode)
Date: Wed, 27 Jul 2016 15:58:14 -0400 [thread overview]
Message-ID: <2fefa17d-37c6-9669-724e-9ee0d841e7b2@mellanox.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1607271452530.9567@east.gentwo.org>
On 7/27/2016 3:53 PM, Christoph Lameter wrote:
> On Wed, 27 Jul 2016, Chris Metcalf wrote:
>
>> Looks good. Did you omit the equivalent fix in clocksource_start_watchdog()
>> on purpose? For now I just took your change, but tweaked it to add the
>> equivalent diff with cpumask_first_and() there.
> Can the watchdog be started on an isolated cpu at all? I would expect that
> the code would start a watchdog only on a housekeeping cpu.
The code just starts the watchdog initially on the first online cpu.
In principle you could have configured that as an isolated cpu, so
without any change to that code, you'd interrupt that cpu.
I guess another way to slice it would be to start the watchdog on the
current core. But just using the same idiom as in clocksource_watchdog()
seems cleanest to me.
I added your patch to the series and pushed it up (along with adding your
Tested-by to the x86 enablement commit). It's still based on 4.6 so I'll need
to rebase it once the merge window closes.
--
Chris Metcalf, Mellanox Technologies
http://www.mellanox.com
next prev parent reply other threads:[~2016-07-27 21:31 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 20:48 [PATCH v13 00/12] support "task_isolation" mode Chris Metcalf
2016-07-14 20:48 ` [PATCH v13 01/12] vmstat: add quiet_vmstat_sync function Chris Metcalf
2016-07-14 20:48 ` [PATCH v13 02/12] vmstat: add vmstat_idle function Chris Metcalf
2016-07-14 20:48 ` [PATCH v13 03/12] lru_add_drain_all: factor out lru_add_drain_needed Chris Metcalf
2016-07-14 20:48 ` [PATCH v13 04/12] task_isolation: add initial support Chris Metcalf
2016-07-14 20:48 ` [PATCH v13 05/12] task_isolation: track asynchronous interrupts Chris Metcalf
2016-07-14 20:48 ` [PATCH v13 06/12] arch/x86: enable task isolation functionality Chris Metcalf
2016-07-14 20:48 ` [PATCH v13 07/12] arm64: factor work_pending state machine to C Chris Metcalf
2016-07-14 20:48 ` [PATCH v13 08/12] arch/arm64: enable task isolation functionality Chris Metcalf
2016-07-14 20:48 ` [PATCH v13 09/12] arch/tile: " Chris Metcalf
2016-07-14 20:48 ` [PATCH v13 10/12] arm, tile: turn off timer tick for oneshot_stopped state Chris Metcalf
2016-07-14 20:48 ` [PATCH v13 11/12] task_isolation: support CONFIG_TASK_ISOLATION_ALL Chris Metcalf
2016-07-14 20:48 ` [PATCH v13 12/12] task_isolation: add user-settable notification signal Chris Metcalf
2016-07-14 21:03 ` [PATCH v13 00/12] support "task_isolation" mode Andy Lutomirski
2016-07-14 21:22 ` Chris Metcalf
2016-07-18 22:11 ` Andy Lutomirski
2016-07-18 22:50 ` Chris Metcalf
2016-07-18 0:42 ` Christoph Lameter
2016-07-21 2:04 ` Christoph Lameter
2016-07-21 14:06 ` Chris Metcalf
2016-07-22 2:20 ` Christoph Lameter
2016-07-22 12:50 ` Chris Metcalf
2016-07-25 16:35 ` Christoph Lameter
2016-07-27 13:55 ` clocksource_watchdog causing scheduling of timers every second (was [v13] support "task_isolation" mode) Christoph Lameter
2016-07-27 14:12 ` Chris Metcalf
2016-07-27 15:23 ` Christoph Lameter
2016-07-27 15:31 ` Christoph Lameter
2016-07-27 17:06 ` Chris Metcalf
2016-07-27 18:56 ` Christoph Lameter
2016-07-27 19:49 ` Chris Metcalf
2016-07-27 19:53 ` Christoph Lameter
2016-07-27 19:58 ` Chris Metcalf [this message]
2016-07-29 18:31 ` Francis Giraldeau
2016-07-29 21:04 ` Chris Metcalf
2016-08-10 22:16 ` Frederic Weisbecker
2016-08-10 22:26 ` Chris Metcalf
2016-08-11 8:40 ` Peter Zijlstra
2016-08-11 11:58 ` Frederic Weisbecker
2016-08-15 15:03 ` Chris Metcalf
2016-08-11 16:00 ` Paul E. McKenney
2016-08-11 23:02 ` Christoph Lameter
2016-08-11 23:47 ` Paul E. McKenney
2016-08-12 14:23 ` Christoph Lameter
2016-08-12 14:26 ` Frederic Weisbecker
2016-08-12 16:19 ` Paul E. McKenney
2016-08-13 15:39 ` Frederic Weisbecker
2016-08-11 8:27 ` [PATCH v13 00/12] support "task_isolation" mode Peter Zijlstra
2016-07-27 14:01 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fefa17d-37c6-9669-724e-9ee0d841e7b2@mellanox.com \
--to=cmetcalf@mellanox.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=cl@linux.com \
--cc=daniel.lezcano@linaro.org \
--cc=fweisbec@gmail.com \
--cc=giladb@mellanox.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®