mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] MIPS: R6: memcpy bugfix - zero length overwrites memory
@ 2015-04-27 23:35 Leonid Yegoshin
  2015-04-28 11:11 ` Jonas Gorski
  0 siblings, 1 reply; 3+ messages in thread
From: Leonid Yegoshin @ 2015-04-27 23:35 UTC (permalink / raw)
  To: linux-mips, markos.chandras, ralf, linux-kernel

MIPS R6 version of memcpy has bug - then length to copy is zero
and addresses are not aligned then it can overwrite a whole memory.

Signed-off-by: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
---
 arch/mips/lib/memcpy.S |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/mips/lib/memcpy.S b/arch/mips/lib/memcpy.S
index 9245e1705e69..7e0250f3aec8 100644
--- a/arch/mips/lib/memcpy.S
+++ b/arch/mips/lib/memcpy.S
@@ -514,6 +514,8 @@
 
 #ifdef CONFIG_CPU_MIPSR6
 .Lcopy_unaligned_bytes\@:
+	beqz    len, .Ldone\@
+	 nop
 1:
 	COPY_BYTE(0)
 	COPY_BYTE(1)


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-04-28 15:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-27 23:35 [PATCH] MIPS: R6: memcpy bugfix - zero length overwrites memory Leonid Yegoshin
2015-04-28 11:11 ` Jonas Gorski
2015-04-28 15:40   ` Leonid Yegoshin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®