From: "Rafał Miłecki" <rafal@milecki.pl>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Julius Werner <jwerner@chromium.org>,
Evan Benn <evanbenn@chromium.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Maxime Ripard <mripard@kernel.org>,
Oleksij Rempel <linux@rempel-privat.de>,
Justin Chen <justinpopo6@gmail.com>,
Baruch Siach <baruch@tkos.co.il>,
Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>,
Marc Zyngier <maz@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Jamie Iles <jamie@jamieiles.com>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
asahi@lists.linux.dev
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention
Date: Mon, 06 Nov 2023 09:10:44 +0100 [thread overview]
Message-ID: <300293570c0d29d5d4a39762121b5bef@milecki.pl> (raw)
In-Reply-To: <20231105184154.43700-1-krzysztof.kozlowski@linaro.org>
On 2023-11-05 19:41, Krzysztof Kozlowski wrote:
> The Devicetree bindings coding convention, as used in most of the files
> and expressed in Documentation/devicetree/bindings/example-schema.yaml,
> expects:
> 1. "allOf:" block just before "properties:" (or after "required:" for
> more complex cases),
> 2. additionalProperties/unevaluatedProperties at the end of the file,
> just before the examples section.
>
> Re-order few schemas to match the convention to avoid repeating review
> comments for new patches using existing code as template. No
> functional
> changes.
It's surely going to help a bit but for a long time solution maybe you
could consider adding proper check to Rob's bot and/or checkpatch.pl.
--
Rafał Miłecki
next prev parent reply other threads:[~2023-11-06 8:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-05 18:41 Krzysztof Kozlowski
2023-11-05 18:41 ` [PATCH 2/2] dt-bindings: watchdog: intel,keembay: reference common watchdog schema Krzysztof Kozlowski
2023-11-05 19:05 ` Guenter Roeck
2023-11-08 16:41 ` Rob Herring
2023-11-05 19:04 ` [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention Guenter Roeck
2023-11-06 8:10 ` Rafał Miłecki [this message]
2023-11-08 16:40 ` Rob Herring
2023-11-08 16:41 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=300293570c0d29d5d4a39762121b5bef@milecki.pl \
--to=rafal@milecki.pl \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=baruch@tkos.co.il \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=evanbenn@chromium.org \
--cc=florian.fainelli@broadcom.com \
--cc=jamie@jamieiles.com \
--cc=jernej.skrabec@gmail.com \
--cc=justinpopo6@gmail.com \
--cc=jwerner@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=linux@roeck-us.net \
--cc=marcan@marcan.st \
--cc=maz@kernel.org \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=sven@svenpeter.dev \
--cc=wan.ahmad.zainie.wan.mohamad@intel.com \
--cc=wens@csie.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®