From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Konrad Dybcio <konradybcio@kernel.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>,
Abel Vesa <abel.vesa@linaro.org>,
Johan Hovold <johan+linaro@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v2] spmi: Fix controller->node != parent->node breakage
Date: Mon, 13 Jan 2025 14:52:09 +0100 [thread overview]
Message-ID: <30474eee-cb88-4250-838a-3969073e0e8d@collabora.com> (raw)
In-Reply-To: <20250113-topic-spmi_node_breakage-v2-1-dd35a3a6daa6@oss.qualcomm.com>
Il 13/01/25 14:02, Konrad Dybcio ha scritto:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> On some platforms, like recent Qualcomm SoCs with multi-bus SPMI
> arbiters, controller->node must be assigned to the individual buses'
> subnodes, as the slave devices are children of these, like so:
>
> arbiter@c400000
> spmi@c42d000
> pmic@0
>
> spmi@c432000
> pmic@0
>
> The commit referenced in Fixes changed that assignment, such that
> spmi_controller_alloc() always assumes the PMICs come directly under
> the arbiter node (which is true when there's only a single bus per
> controller).
>
> Make controller->node specifiable to both benefit from Joe's refcount
> improvements and un-break the aforementioned platforms.
>
> Fixes: 821b07853e32 ("spmi: hisi-spmi-controller: manage the OF node reference in device initialization and cleanup")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
for spmi.c/.h, spmi-devres and for MediaTek:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cheers!
next prev parent reply other threads:[~2025-01-13 13:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 13:02 Konrad Dybcio
2025-01-13 13:52 ` AngeloGioacchino Del Regno [this message]
2025-01-13 21:52 ` Stephen Boyd
2025-01-13 22:12 ` Konrad Dybcio
2025-01-14 18:30 ` Stephen Boyd
2025-01-14 20:37 ` Konrad Dybcio
2025-01-15 23:16 ` Stephen Boyd
2025-01-16 4:54 ` Joe Hattori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30474eee-cb88-4250-838a-3969073e0e8d@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=abel.vesa@linaro.org \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=joe@pf.is.s.u-tokyo.ac.jp \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=marijn.suijten@somainline.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab+huawei@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®