From: David Howells <dhowells@redhat.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: dhowells@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
kernel-hardening@lists.openwall.com
Subject: Re: [PATCH v8 3/5] rxrpc: check return value of skb_to_sgvec always
Date: Mon, 15 May 2017 14:11:19 +0100 [thread overview]
Message-ID: <30529.1494853879@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170511194134.31183-4-Jason@zx2c4.com>
Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> + if (unlikely(skb_to_sgvec(skb, sg, offset, 8) < 0))
> + goto nomem;
> ...
> + if (unlikely(skb_to_sgvec(skb, sg, offset, len) < 0)) {
> + if (sg != _sg)
> + kfree(sg);
> + goto nomem;
skb_to_sgvec() can return -EMSGSIZE in some circumstances. You shouldn't
return -ENOMEM here in such a case.
David
next prev parent reply other threads:[~2017-05-15 13:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 19:41 [PATCH v8 0/5] skb_to_sgvec hardening Jason A. Donenfeld
2017-05-11 19:41 ` [PATCH v8 1/5] skbuff: return -EMSGSIZE in skb_to_sgvec to prevent overflow Jason A. Donenfeld
2017-05-11 19:41 ` [PATCH v8 2/5] ipsec: check return value of skb_to_sgvec always Jason A. Donenfeld
2017-05-11 19:41 ` [PATCH v8 3/5] rxrpc: " Jason A. Donenfeld
2017-05-11 19:41 ` [PATCH v8 4/5] macsec: " Jason A. Donenfeld
2017-05-11 19:41 ` [PATCH v8 5/5] virtio_net: " Jason A. Donenfeld
2017-05-15 13:11 ` David Howells [this message]
2017-05-16 22:11 ` [PATCH v8 3/5] rxrpc: " Jason A. Donenfeld
2017-05-15 13:12 ` [PATCH v8 1/5] skbuff: return -EMSGSIZE in skb_to_sgvec to prevent overflow David Howells
2017-05-16 22:11 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30529.1494853879@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=Jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®