mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Peter Zijlstra <peterz@infradead.org>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux PM list <linux-pm@vger.kernel.org>,
	Linux PCI <linux-pci@vger.kernel.org>,
	Zhang Rui <rui.zhang@intel.com>
Subject: Re: [Update 2x][PATCH 1/2] ACPI / PM: Always enable wakeup GPEs when enabling device wakeup
Date: Tue, 22 Jul 2014 03:02:29 +0200	[thread overview]
Message-ID: <30566603.pYsRuTlO6S@vostro.rjw.lan> (raw)
In-Reply-To: <20140721081734.GL3935@laptop>

On Monday, July 21, 2014 10:17:34 AM Peter Zijlstra wrote:
> On Mon, Jul 21, 2014 at 01:51:46AM +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Subject: ACPI / PM: Always enable wakeup GPEs when enabling device wakeup
> > 
> > Wakeup GPEs are currently only enabled when setting up devices for
> > remote wakeup at run time.  During system-wide transitions they are
> > enabled by ACPICA at the very last stage of suspend (before asking
> > the BIOS to take over).  Of course, that only works for system
> > sleep states supported by ACPI, so in particular it doesn't work
> > for the "freeze" sleep state.
> > 
> > For this reason, modify the ACPI core device PM code to enable wakeup
> > GPEs for devices when setting them up for wakeup regardless of whether
> > that is remote wakeup at runtime or system wakeup.  That allows the
> > same device wakeup setup routine to be used for both runtime PM and
> > system-wide PM and makes it possible to reduce code size quite a bit.
> > 
> > That should make things like ACPI-based PCI Wake-on-LAN work with
> > the "freeze" sleep state among other things.
> > 
> > Tested-on: Toshiba Portege R500
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > ---
> > 
> > The PCI ACPI device PM notify handler has to be updated to avoid running
> > runtime resume callbacks during system suspend too.
> 
> So I tested the first version, with that my WSM-EP didn't resume on WoL
> and pressing the power button after the WoL had it crash and burn in the
> igb driver.
> 
> Today I tested this latest version and WoL still didn't trigger a
> resume, but the power button did make it go again, no crashes and I
> suppose I can confirm the earlier patch that stopped making it go halt
> works.

OK, thanks!

> When I 'halt' I can wake the machine back up using a WoL so that all
> _should_ work afaik.

Yes, it should.

I'll send an updated patchset shortly, so please test that one.  If it
doesn't help, we'll need to dig deeper still.

Rafael


  reply	other threads:[~2014-07-22  0:44 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-19 20:36 [PATCH 0/2] ACPI / PM: Make ACPI-based PCI wakeup work for the "freeze" sleep state Rafael J. Wysocki
2014-07-19 20:37 ` [PATCH 1/2] ACPI / PM: Always enable wakeup GPEs when enabling device wakeup Rafael J. Wysocki
2014-07-20  7:17   ` [Update][PATCH " Rafael J. Wysocki
2014-07-20 23:51     ` [Update 2x][PATCH " Rafael J. Wysocki
2014-07-21  8:17       ` Peter Zijlstra
2014-07-22  1:02         ` Rafael J. Wysocki [this message]
2014-07-19 20:38 ` [PATCH 2/2] ACPI / PM: Rename acpi_wakeup_device() to acpi_device_pm_event() Rafael J. Wysocki
2014-07-22  1:23 ` [PATCH 0/3] ACPI / PM: Make ACPI-based PCI wakeup work for the "freeze" sleep state Rafael J. Wysocki
2014-07-22  1:24   ` [PATCH 1/3] PM: Create PM workqueue if runtime PM is not configured too Rafael J. Wysocki
2014-07-22  1:25   ` [PATCH 2/3] ACPI / PM: Revork the handling of ACPI device wakeup notifications Rafael J. Wysocki
2014-07-22 12:29     ` [Update][PATCH " Rafael J. Wysocki
2014-07-22  1:26   ` [PATCH 3/3] ACPI / PM: Always enable wakeup GPEs when enabling device wakeup Rafael J. Wysocki
2014-07-22  8:55   ` [PATCH 0/3] ACPI / PM: Make ACPI-based PCI wakeup work for the "freeze" sleep state Peter Zijlstra
2014-07-22  9:42     ` Peter Zijlstra
2014-07-22 12:23     ` Rafael J. Wysocki
2014-07-22 12:13       ` Peter Zijlstra
2014-07-22 22:26         ` Rafael J. Wysocki
2014-07-23  7:28           ` Peter Zijlstra
2014-07-23 11:43             ` Rafael J. Wysocki
2014-07-23 11:38               ` Peter Zijlstra
2014-07-23 12:17                 ` Rafael J. Wysocki
2014-07-23 12:04                   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30566603.pYsRuTlO6S@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®