mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Peter Zijlstra <peterz@infradead.org>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux PM list <linux-pm@vger.kernel.org>,
	Linux PCI <linux-pci@vger.kernel.org>,
	Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH 0/3] ACPI / PM: Make ACPI-based PCI wakeup work for the "freeze" sleep state
Date: Wed, 23 Jul 2014 14:17:55 +0200	[thread overview]
Message-ID: <6491652.ycQtdn67HU@vostro.rjw.lan> (raw)
In-Reply-To: <20140723113840.GJ20603@laptop.programming.kicks-ass.net>

On Wednesday, July 23, 2014 01:38:40 PM Peter Zijlstra wrote:
> On Wed, Jul 23, 2014 at 01:43:59PM +0200, Rafael J. Wysocki wrote:
> > On Wednesday, July 23, 2014 09:28:50 AM Peter Zijlstra wrote:
> > > On Wed, Jul 23, 2014 at 12:26:20AM +0200, Rafael J. Wysocki wrote:
> > > > All of that indicates that the machine in question has WoL based on native PCIe
> > > > PME signaling.  In that case it doesn't wake up from the "freeze" state, because
> > > > some code is missing.
> > > 
> > > Didn't wake, but it did show:
> > > 
> > > 0000:00:01.0:pcie01     1               1               0               0               0               0               0               99207           0
> > > LNXPWRBN:00             1               1               0               0               0               0               0               99191           0
> > > 
> > > So at least something's moving, although its not quite working yet.
> > 
> > That may be because I forgot about one piece, sorry about that.
> > This patch:
> > 
> > https://patchwork.kernel.org/patch/4526561/
> > 
> > (which I think is in tip already) is needed to make enable_irq_wake()
> > work with the "freeze" state.
> > 
> > Can you please apply this in addition and retest?
> 
> I appear to have that hunk already (I'm running -tip based kernels).

I see.

> (also, patchwork blows chunks :/)

That's never happened to me (and there's only one hunk in that patch).

Anyway, the count for 0000:00:01.0:pcie01 means that the wakeup source
has been activated, so it should have woken it up in theory.

Unless, of course, it was activated after the power button wakeup.

It looks like the stuff works on the hardware level, though, so we should be
able to make the wakeup work too.  I'll have another look later today.

Rafael


  reply	other threads:[~2014-07-23 11:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-19 20:36 [PATCH 0/2] " Rafael J. Wysocki
2014-07-19 20:37 ` [PATCH 1/2] ACPI / PM: Always enable wakeup GPEs when enabling device wakeup Rafael J. Wysocki
2014-07-20  7:17   ` [Update][PATCH " Rafael J. Wysocki
2014-07-20 23:51     ` [Update 2x][PATCH " Rafael J. Wysocki
2014-07-21  8:17       ` Peter Zijlstra
2014-07-22  1:02         ` Rafael J. Wysocki
2014-07-19 20:38 ` [PATCH 2/2] ACPI / PM: Rename acpi_wakeup_device() to acpi_device_pm_event() Rafael J. Wysocki
2014-07-22  1:23 ` [PATCH 0/3] ACPI / PM: Make ACPI-based PCI wakeup work for the "freeze" sleep state Rafael J. Wysocki
2014-07-22  1:24   ` [PATCH 1/3] PM: Create PM workqueue if runtime PM is not configured too Rafael J. Wysocki
2014-07-22  1:25   ` [PATCH 2/3] ACPI / PM: Revork the handling of ACPI device wakeup notifications Rafael J. Wysocki
2014-07-22 12:29     ` [Update][PATCH " Rafael J. Wysocki
2014-07-22  1:26   ` [PATCH 3/3] ACPI / PM: Always enable wakeup GPEs when enabling device wakeup Rafael J. Wysocki
2014-07-22  8:55   ` [PATCH 0/3] ACPI / PM: Make ACPI-based PCI wakeup work for the "freeze" sleep state Peter Zijlstra
2014-07-22  9:42     ` Peter Zijlstra
2014-07-22 12:23     ` Rafael J. Wysocki
2014-07-22 12:13       ` Peter Zijlstra
2014-07-22 22:26         ` Rafael J. Wysocki
2014-07-23  7:28           ` Peter Zijlstra
2014-07-23 11:43             ` Rafael J. Wysocki
2014-07-23 11:38               ` Peter Zijlstra
2014-07-23 12:17                 ` Rafael J. Wysocki [this message]
2014-07-23 12:04                   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6491652.ycQtdn67HU@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®