mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Muchun Song <muchun.song@linux.dev>
To: 傅清爽 <fuqingshuang@kylinos.cn>
Cc: fffsqian <fffsqian@163.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dave Chinner <david@fromorbit.com>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Qi Zheng <qi.zheng@linux.dev>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH 1/1] mm/shrinker: add NULL checks after rcu_dereference() in shrinker bit functions
Date: Fri, 26 Jun 2026 11:49:13 +0800	[thread overview]
Message-ID: <305C42A2-1359-4998-A95C-49998B4660DB@linux.dev> (raw)
In-Reply-To: <6l2gs76zo6zf-6l2n5wa2xbvg@nsmail8.2--kylin--1>



> On Jun 25, 2026, at 11:01, 傅清爽 <fuqingshuang@kylinos.cn> wrote:
> 
> Hi Qi, 
>  
> Thank you very much for your detailed analysis and patient explanation. 
> I fully understand your point that the existing caller constraints guarantee shrinker_info cannot be NULL here, and this NULL check is unnecessary defensive code.

Thanks for your contribution! I have a couple of quick suggestions to
help things go smoother:

- Please take a closer look at our community communication guidelines,
  as we rely on plain-text-based replies here.

- For any issues you're not completely sure about, it would be awesome
  if you could run a quick validation yourself before sending out a patch.
  Maintainers' time is quite limited, so this helps everyone save a lot
  of energy and speeds up the review process.

Thanks for understanding, and looking forward to your next patch!

Thanks,
Muchun


  reply	other threads:[~2026-06-26  3:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-24  9:55 fffsqian
2026-06-24 10:49 ` Qi Zheng
2026-06-25  3:01   ` 傅清爽
2026-06-26  3:49     ` Muchun Song [this message]
2026-06-26  6:28       ` fffsqian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=305C42A2-1359-4998-A95C-49998B4660DB@linux.dev \
    --to=muchun.song@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=david@fromorbit.com \
    --cc=fffsqian@163.com \
    --cc=fuqingshuang@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=qi.zheng@linux.dev \
    --cc=roman.gushchin@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®