mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hal Feng <hal.feng@starfivetech.com>
To: Philipp Zabel <p.zabel@pengutronix.de>, <linux-kernel@vger.kernel.org>
Cc: Emil Renner Berthing <kernel@esmil.dk>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] reset: starfive: select AUXILIARY_BUS
Date: Thu, 4 May 2023 10:38:09 +0800	[thread overview]
Message-ID: <307a7656-df3d-2e67-d07b-c5a2941c145b@starfivetech.com> (raw)
In-Reply-To: <20230502102050.1418417-1-p.zabel@pengutronix.de>

On Tue, 2 May 2023 12:20:50 +0200, Philipp Zabel wrote:
> CONFIG_AUXILIARY_BUS is not a user-visible symbol, replace 'depends on'
> with 'select'.
> 
> Cc: Emil Renner Berthing <kernel@esmil.dk>
> Cc: Hal Feng <hal.feng@starfivetech.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

Reviewed-by: Hal Feng <hal.feng@starfivetech.com>

> ---
>  drivers/reset/starfive/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/reset/starfive/Kconfig b/drivers/reset/starfive/Kconfig
> index 1fa706a2c3dc..d832339f61bc 100644
> --- a/drivers/reset/starfive/Kconfig
> +++ b/drivers/reset/starfive/Kconfig
> @@ -13,7 +13,8 @@ config RESET_STARFIVE_JH7100
>  
>  config RESET_STARFIVE_JH7110
>  	bool "StarFive JH7110 Reset Driver"
> -	depends on AUXILIARY_BUS && CLK_STARFIVE_JH7110_SYS
> +	depends on CLK_STARFIVE_JH7110_SYS
> +	select AUXILIARY_BUS
>  	select RESET_STARFIVE_JH71X0
>  	default ARCH_STARFIVE
>  	help


      parent reply	other threads:[~2023-05-04  2:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-02 10:20 Philipp Zabel
2023-05-02 11:40 ` Emil Renner Berthing
2023-05-02 12:05 ` Arnd Bergmann
2023-05-04  2:38 ` Hal Feng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=307a7656-df3d-2e67-d07b-c5a2941c145b@starfivetech.com \
    --to=hal.feng@starfivetech.com \
    --cc=arnd@arndb.de \
    --cc=kernel@esmil.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®