* [PATCH] reset: starfive: select AUXILIARY_BUS
@ 2023-05-02 10:20 Philipp Zabel
2023-05-02 11:40 ` Emil Renner Berthing
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Philipp Zabel @ 2023-05-02 10:20 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Emil Renner Berthing, Hal Feng, Arnd Bergmann
CONFIG_AUXILIARY_BUS is not a user-visible symbol, replace 'depends on'
with 'select'.
Cc: Emil Renner Berthing <kernel@esmil.dk>
Cc: Hal Feng <hal.feng@starfivetech.com>
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/reset/starfive/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/starfive/Kconfig b/drivers/reset/starfive/Kconfig
index 1fa706a2c3dc..d832339f61bc 100644
--- a/drivers/reset/starfive/Kconfig
+++ b/drivers/reset/starfive/Kconfig
@@ -13,7 +13,8 @@ config RESET_STARFIVE_JH7100
config RESET_STARFIVE_JH7110
bool "StarFive JH7110 Reset Driver"
- depends on AUXILIARY_BUS && CLK_STARFIVE_JH7110_SYS
+ depends on CLK_STARFIVE_JH7110_SYS
+ select AUXILIARY_BUS
select RESET_STARFIVE_JH71X0
default ARCH_STARFIVE
help
--
2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] reset: starfive: select AUXILIARY_BUS
2023-05-02 10:20 [PATCH] reset: starfive: select AUXILIARY_BUS Philipp Zabel
@ 2023-05-02 11:40 ` Emil Renner Berthing
2023-05-02 12:05 ` Arnd Bergmann
2023-05-04 2:38 ` Hal Feng
2 siblings, 0 replies; 4+ messages in thread
From: Emil Renner Berthing @ 2023-05-02 11:40 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, Hal Feng, Arnd Bergmann
On Tue, 2 May 2023 at 12:20, Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> CONFIG_AUXILIARY_BUS is not a user-visible symbol, replace 'depends on'
> with 'select'.
>
> Cc: Emil Renner Berthing <kernel@esmil.dk>
> Cc: Hal Feng <hal.feng@starfivetech.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Makes sense to me. Thanks!
Reviewed-by: <emil.renner.berthing@canonical.com>
> ---
> drivers/reset/starfive/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/starfive/Kconfig b/drivers/reset/starfive/Kconfig
> index 1fa706a2c3dc..d832339f61bc 100644
> --- a/drivers/reset/starfive/Kconfig
> +++ b/drivers/reset/starfive/Kconfig
> @@ -13,7 +13,8 @@ config RESET_STARFIVE_JH7100
>
> config RESET_STARFIVE_JH7110
> bool "StarFive JH7110 Reset Driver"
> - depends on AUXILIARY_BUS && CLK_STARFIVE_JH7110_SYS
> + depends on CLK_STARFIVE_JH7110_SYS
> + select AUXILIARY_BUS
> select RESET_STARFIVE_JH71X0
> default ARCH_STARFIVE
> help
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] reset: starfive: select AUXILIARY_BUS
2023-05-02 10:20 [PATCH] reset: starfive: select AUXILIARY_BUS Philipp Zabel
2023-05-02 11:40 ` Emil Renner Berthing
@ 2023-05-02 12:05 ` Arnd Bergmann
2023-05-04 2:38 ` Hal Feng
2 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2023-05-02 12:05 UTC (permalink / raw)
To: Philipp Zabel, linux-kernel; +Cc: Emil Renner Berthing, Hal Feng
On Tue, May 2, 2023, at 12:20, Philipp Zabel wrote:
> CONFIG_AUXILIARY_BUS is not a user-visible symbol, replace 'depends on'
> with 'select'.
>
> Cc: Emil Renner Berthing <kernel@esmil.dk>
> Cc: Hal Feng <hal.feng@starfivetech.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] reset: starfive: select AUXILIARY_BUS
2023-05-02 10:20 [PATCH] reset: starfive: select AUXILIARY_BUS Philipp Zabel
2023-05-02 11:40 ` Emil Renner Berthing
2023-05-02 12:05 ` Arnd Bergmann
@ 2023-05-04 2:38 ` Hal Feng
2 siblings, 0 replies; 4+ messages in thread
From: Hal Feng @ 2023-05-04 2:38 UTC (permalink / raw)
To: Philipp Zabel, linux-kernel; +Cc: Emil Renner Berthing, Arnd Bergmann
On Tue, 2 May 2023 12:20:50 +0200, Philipp Zabel wrote:
> CONFIG_AUXILIARY_BUS is not a user-visible symbol, replace 'depends on'
> with 'select'.
>
> Cc: Emil Renner Berthing <kernel@esmil.dk>
> Cc: Hal Feng <hal.feng@starfivetech.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Hal Feng <hal.feng@starfivetech.com>
> ---
> drivers/reset/starfive/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/starfive/Kconfig b/drivers/reset/starfive/Kconfig
> index 1fa706a2c3dc..d832339f61bc 100644
> --- a/drivers/reset/starfive/Kconfig
> +++ b/drivers/reset/starfive/Kconfig
> @@ -13,7 +13,8 @@ config RESET_STARFIVE_JH7100
>
> config RESET_STARFIVE_JH7110
> bool "StarFive JH7110 Reset Driver"
> - depends on AUXILIARY_BUS && CLK_STARFIVE_JH7110_SYS
> + depends on CLK_STARFIVE_JH7110_SYS
> + select AUXILIARY_BUS
> select RESET_STARFIVE_JH71X0
> default ARCH_STARFIVE
> help
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-04 2:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-02 10:20 [PATCH] reset: starfive: select AUXILIARY_BUS Philipp Zabel
2023-05-02 11:40 ` Emil Renner Berthing
2023-05-02 12:05 ` Arnd Bergmann
2023-05-04 2:38 ` Hal Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®