Re: [PATCH 25/74] media: qcom: camss: vfe: Define output based VFE controls

["Gjorgji Rosikopulos (Consultant)" <gjorgji.rosikopulos@oss.qualcomm.com>]

Hi Bryan,

On 10/5/2026 8:13 PM, Bryan O'Donoghue wrote:
> Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
> ---
>  drivers/media/platform/qcom/camss/camss-vfe.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.h b/drivers/media/platform/qcom/camss/camss-vfe.h
> index 6ba0d0c7d6be2..bf8dccf4c901e 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.h
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.h
> @@ -168,12 +168,22 @@ struct vfe_hw_ops {
>  	int (*vfe_enable)(struct vfe_line *line);
>  	int (*vfe_halt)(struct vfe_device *vfe);
>  	void (*violation_read)(struct vfe_device *vfe);
> +
> +	/* RDI based API - deprecated */
>  	void (*vfe_wm_start)(struct vfe_device *vfe, u8 wm,
>  			     struct vfe_line *line);
>  	void (*vfe_wm_stop)(struct vfe_device *vfe, u8 wm);
>  	void (*vfe_buf_done)(struct vfe_device *vfe, int port_id);
>  	void (*vfe_wm_update)(struct vfe_device *vfe, u8 wm, u32 addr,
>  			      struct vfe_line *line);
> +
> +	/* Output based API - new and shiny */
> +	void (*vfe_output_start)(struct vfe_device *vfe, struct vfe_output *output);
> +	void (*vfe_output_stop)(struct vfe_device *vfe, struct vfe_output *output);
> +	void (*vfe_output_buf_done)(struct vfe_device *vfe, struct vfe_output *output);
> +	void (*vfe_output_update)(struct vfe_device *vfe, struct vfe_output *output,
> +				  struct camss_buffer *buf);
> +

This also deserves good commit message, this is exact copy of the other RDI API with other arguments :-) Shall we migrate
all existing drivers to this api in respect to use other deprecated API but having both of them leave in vfe file which 
creates even more confusion and readability of the code?

~Gjorgji