Re: [PATCH 24/74] media: qcom: camss: vfe: Define vfe v3 completion group enum

["Gjorgji Rosikopulos (Consultant)" <gjorgji.rosikopulos@oss.qualcomm.com>]

Hi Bryan, 

On 10/5/2026 8:13 PM, Bryan O'Donoghue wrote:
> Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
> ---
>  drivers/media/platform/qcom/camss/camss-vfe.h | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.h b/drivers/media/platform/qcom/camss/camss-vfe.h
> index 925b0e59f9605..6ba0d0c7d6be2 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.h
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.h
> @@ -78,6 +78,27 @@ enum vfe_packer_format_v3 {
>  	VFE_BUS_WM_PACKER_FMT_V3_MAX,
>  };
>  
> +enum vfe_v3_comp_group {
> +	VFE_V3_COMP_GRP_0,
> +	VFE_V3_COMP_GRP_1,
> +	VFE_V3_COMP_GRP_2,
> +	VFE_V3_COMP_GRP_3,
> +	VFE_V3_COMP_GRP_4,
> +	VFE_V3_COMP_GRP_5,
> +	VFE_V3_COMP_GRP_6,
> +	VFE_V3_COMP_GRP_7,
> +	VFE_V3_COMP_GRP_8,
> +	VFE_V3_COMP_GRP_9,
> +	VFE_V3_COMP_GRP_10,
> +	VFE_V3_COMP_GRP_11,
> +	VFE_V3_COMP_GRP_12,
> +	VFE_V3_COMP_GRP_13,
> +	VFE_V3_COMP_GRP_14,
> +	VFE_V3_COMP_GRP_15,
> +	VFE_V3_COMP_GRP_16,
> +	VFE_V3_COMP_GRP_MAX,

Can we use numbers i dont see reason to have enum with _0, _1
but it is matter of taste maybe.

> +};
> +
>  struct vfe_wm {
>  	u8 bus_client;
>  };

Can we get at least what this bus_cleant means as comment to the structure or commit message?

~Gjorgji