* [PATCH] hwmon: (it87) Add support for IT8625E
@ 2024-10-22 8:14 Ai Chao
2024-10-22 8:20 ` Christophe JAILLET
0 siblings, 1 reply; 3+ messages in thread
From: Ai Chao @ 2024-10-22 8:14 UTC (permalink / raw)
To: jdelvare, linux, linux-hwmon, linux-kernel; +Cc: Ai Chao
Add support for IT8625E on Centerm P410.
Signed-off-by: Ai Chao <aichao@kylinos.cn>
---
drivers/hwmon/it87.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
index e233aafa8856..fac7b10d51bc 100644
--- a/drivers/hwmon/it87.c
+++ b/drivers/hwmon/it87.c
@@ -15,6 +15,7 @@
* IT8620E Super I/O chip w/LPC interface
* IT8622E Super I/O chip w/LPC interface
* IT8623E Super I/O chip w/LPC interface
+ * IT8625E Super I/O chip w/LPC interface
* IT8628E Super I/O chip w/LPC interface
* IT8705F Super I/O chip w/LPC interface
* IT8712F Super I/O chip w/LPC interface
@@ -163,6 +164,7 @@ static inline void superio_exit(int ioreg, bool noexit)
#define IT8623E_DEVID 0x8623
#define IT8628E_DEVID 0x8628
#define IT87952E_DEVID 0x8695
+#define IT8625E_DEVID 0x8625
/* Logical device 4 (Environmental Monitor) registers */
#define IT87_ACT_REG 0x30
@@ -2782,6 +2784,7 @@ static int __init it87_find(int sioaddr, unsigned short *address,
case IT8622E_DEVID:
sio_data->type = it8622;
break;
+ case IT8625E_DEVID:
case IT8628E_DEVID:
sio_data->type = it8628;
break;
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: (it87) Add support for IT8625E
2024-10-22 8:14 [PATCH] hwmon: (it87) Add support for IT8625E Ai Chao
@ 2024-10-22 8:20 ` Christophe JAILLET
2024-10-22 8:20 ` Christophe JAILLET
0 siblings, 1 reply; 3+ messages in thread
From: Christophe JAILLET @ 2024-10-22 8:20 UTC (permalink / raw)
To: Ai Chao, jdelvare, linux, linux-hwmon, linux-kernel
Le 22/10/2024 à 10:14, Ai Chao a écrit :
> Add support for IT8625E on Centerm P410.
>
> Signed-off-by: Ai Chao <aichao@kylinos.cn>
> ---
> drivers/hwmon/it87.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
> index e233aafa8856..fac7b10d51bc 100644
> --- a/drivers/hwmon/it87.c
> +++ b/drivers/hwmon/it87.c
> @@ -15,6 +15,7 @@
> * IT8620E Super I/O chip w/LPC interface
> * IT8622E Super I/O chip w/LPC interface
> * IT8623E Super I/O chip w/LPC interface
> + * IT8625E Super I/O chip w/LPC interface
> * IT8628E Super I/O chip w/LPC interface
> * IT8705F Super I/O chip w/LPC interface
> * IT8712F Super I/O chip w/LPC interface
> @@ -163,6 +164,7 @@ static inline void superio_exit(int ioreg, bool noexit)
> #define IT8623E_DEVID 0x8623
> #define IT8628E_DEVID 0x8628
> #define IT87952E_DEVID 0x8695
> +#define IT8625E_DEVID 0x8625
Maybe also keep things ordered here and add the #define after IT8623E_DEVID?
CJ
>
> /* Logical device 4 (Environmental Monitor) registers */
> #define IT87_ACT_REG 0x30
> @@ -2782,6 +2784,7 @@ static int __init it87_find(int sioaddr, unsigned short *address,
> case IT8622E_DEVID:
> sio_data->type = it8622;
> break;
> + case IT8625E_DEVID:
> case IT8628E_DEVID:
> sio_data->type = it8628;
> break;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: (it87) Add support for IT8625E
2024-10-22 8:20 ` Christophe JAILLET
@ 2024-10-22 8:20 ` Christophe JAILLET
0 siblings, 0 replies; 3+ messages in thread
From: Christophe JAILLET @ 2024-10-22 8:20 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-hwmon
Le 22/10/2024 à 10:14, Ai Chao a écrit :
> Add support for IT8625E on Centerm P410.
>
> Signed-off-by: Ai Chao <aichao@kylinos.cn>
> ---
> drivers/hwmon/it87.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
> index e233aafa8856..fac7b10d51bc 100644
> --- a/drivers/hwmon/it87.c
> +++ b/drivers/hwmon/it87.c
> @@ -15,6 +15,7 @@
> * IT8620E Super I/O chip w/LPC interface
> * IT8622E Super I/O chip w/LPC interface
> * IT8623E Super I/O chip w/LPC interface
> + * IT8625E Super I/O chip w/LPC interface
> * IT8628E Super I/O chip w/LPC interface
> * IT8705F Super I/O chip w/LPC interface
> * IT8712F Super I/O chip w/LPC interface
> @@ -163,6 +164,7 @@ static inline void superio_exit(int ioreg, bool noexit)
> #define IT8623E_DEVID 0x8623
> #define IT8628E_DEVID 0x8628
> #define IT87952E_DEVID 0x8695
> +#define IT8625E_DEVID 0x8625
Maybe also keep things ordered here and add the #define after IT8623E_DEVID?
CJ
>
> /* Logical device 4 (Environmental Monitor) registers */
> #define IT87_ACT_REG 0x30
> @@ -2782,6 +2784,7 @@ static int __init it87_find(int sioaddr, unsigned short *address,
> case IT8622E_DEVID:
> sio_data->type = it8622;
> break;
> + case IT8625E_DEVID:
> case IT8628E_DEVID:
> sio_data->type = it8628;
> break;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-22 8:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-22 8:14 [PATCH] hwmon: (it87) Add support for IT8625E Ai Chao
2024-10-22 8:20 ` Christophe JAILLET
2024-10-22 8:20 ` Christophe JAILLET
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®