From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Allen Yu <alleny@nvidia.com>, Pavel Machek <pavel@ucw.cz>,
Len Brown <len.brown@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] PM / Runtime: let rpm_resume fail if rpm disabled and device suspended.
Date: Wed, 25 Jun 2014 01:38:43 +0200 [thread overview]
Message-ID: <3098868.U0NfB8kYvJ@vostro.rjw.lan> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1406221239060.17183-100000@netrider.rowland.org>
On Sunday, June 22, 2014 12:45:42 PM Alan Stern wrote:
> On Sun, 22 Jun 2014, Rafael J. Wysocki wrote:
>
> > > How would you treat them specially? Add a "runtime_pm_not_supported"
> > > flag?
> >
> > I thought about a "runtime PM has been enabled at least once" flag rather
> > that would be set by pm_runtime_enable() every time it is called and never
> > cleared. That would allow the core to distinguish between "runtime PM
> > disabled temporarily" and "runtime PM not used" which turn out to be
> > sufficiently different cases.
>
> Interesting idea, but it can't tell the difference between "runtime PM
> not supported" and "runtime PM not enabled yet". I think a simple "not
> supported" flag will be more straightforward.
The question is who will set the "unsupported" flag (think devices without
drivers etc.). Or perhaps the idea is that it will be set to start with?
> > Yes. The core definitely needs to be able to distinguish between the
> > "runtime PM disabled temporarily" and "runtime PM not supported/not used"
> > situations.
>
> Let me work out a patch, and we'll see what you think. For the time
> being we can stick with our "runtime PM must be disabled (or in error)
> when the status is changed" approach.
OK
Rafael
next prev parent reply other threads:[~2014-06-24 23:21 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-14 10:03 Allen Yu
2014-06-14 14:32 ` Alan Stern
2014-06-16 3:03 ` Allen Yu
2014-06-16 14:43 ` Alan Stern
2014-06-16 17:40 ` Alan Stern
2014-06-16 21:29 ` Rafael J. Wysocki
2014-06-17 14:11 ` Alan Stern
2014-06-17 20:26 ` Rafael J. Wysocki
2014-06-17 20:37 ` Rafael J. Wysocki
2014-06-17 20:46 ` Rafael J. Wysocki
2014-06-18 15:30 ` Alan Stern
2014-06-18 23:57 ` Rafael J. Wysocki
2014-06-19 8:23 ` Allen Yu
2014-06-19 13:55 ` Rafael J. Wysocki
2014-06-19 14:34 ` Allen Yu
2014-06-20 14:04 ` Rafael J. Wysocki
2014-06-19 14:56 ` Alan Stern
2014-06-19 19:25 ` Kevin Hilman
2014-06-19 20:13 ` Alan Stern
2014-06-20 13:20 ` Rafael J. Wysocki
2014-06-20 14:48 ` Alan Stern
2014-06-20 21:34 ` Kevin Hilman
2014-06-22 13:40 ` Rafael J. Wysocki
2014-06-22 13:24 ` Rafael J. Wysocki
2014-06-20 21:31 ` Kevin Hilman
2014-06-21 13:34 ` Alan Stern
2014-06-22 13:35 ` Rafael J. Wysocki
2014-06-23 18:57 ` Kevin Hilman
2014-06-19 14:34 ` Alan Stern
2014-06-20 13:33 ` Rafael J. Wysocki
2014-06-20 14:43 ` Alan Stern
2014-06-22 13:21 ` Rafael J. Wysocki
2014-06-22 16:45 ` Alan Stern
2014-06-24 23:38 ` Rafael J. Wysocki [this message]
2014-06-27 18:27 ` [RFC] Add "rpm_not_supported" flag Alan Stern
2014-06-27 19:22 ` Greg Kroah-Hartman
2014-06-27 20:11 ` Alan Stern
2014-06-27 20:50 ` Greg Kroah-Hartman
2014-06-28 15:32 ` Alan Stern
2014-06-30 13:52 ` Rafael J. Wysocki
2014-06-30 14:42 ` Alan Stern
2014-07-01 23:18 ` Rafael J. Wysocki
2014-07-02 14:27 ` Alan Stern
2014-07-02 17:56 ` Greg Kroah-Hartman
2014-07-03 21:16 ` Rafael J. Wysocki
2014-07-03 21:17 ` Alan Stern
2014-07-16 22:40 ` Rafael J. Wysocki
2014-07-16 23:03 ` Greg Kroah-Hartman
2014-07-16 23:27 ` Rafael J. Wysocki
2014-07-17 14:27 ` Alan Stern
2014-07-18 0:48 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3098868.U0NfB8kYvJ@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=alleny@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®