mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Miotsuki Mizuno <founder@crepuse.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Icenowy Zheng <icenowy@aosc.io>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] dt-bindings: input: touchscreen: add Nsiway NS2009
Date: Sat, 10 Oct 2026 22:13:41 -0700	[thread overview]
Message-ID: <30c56291bac612db47c6ced73dff739f@gmail.com> (raw)
In-Reply-To: <20261009144729.85832-3-founder@crepuse.com>

Hi Miotsuki,

On Fri, Oct 09, 2026 at 02:47:43PM +0000, Miotsuki Mizuno wrote:
> Describe the Nsiway NS2009 four-wire resistive touchscreen controller
> and the properties used by its polling driver.
>
> The controller returns 12-bit ADC coordinates. Use the common touchscreen
> properties for coordinate ranges and orientation, and allow boards to set
> the raw Z1 contact threshold through touchscreen-min-pressure. Limit that
> threshold to 1..4095 because zero cannot distinguish a released contact.
>
> Document the historical default of 80 and a board override of 150 in the
> example. The Z1 threshold is for contact detection, not calibrated
> pressure.
>
> Signed-off-by: Mizuno Miotsuki <founder@crepuse.com>
> ---
...
> +description: |
> +  The NS2009 is a four-wire resistive touchscreen controller connected over
> +  I2C. This binding describes polling operation without a pen interrupt.
> +  Coordinates are 12-bit ADC readings, not display pixel coordinates.

Devicetree bindings should describe the hardware itself rather than the
subset of features currently used by the Linux driver. According to the
NS2009 datasheet, the controller has several hardware signals and
capabilities that should be covered in the binding from the start (even
if the initial driver operates in polling mode):

  - interrupts (maxItems: 1) and wakeup-source: the controller provides
    an active-low pen interrupt output, which can remain optional for
    boards where the line is left unconnected.
  - vdd-supply and vref-supply: main power supply and external reference
    voltage regulators.
  - touchscreen-x-plate-ohms (along with touchscreen-max-pressure and
    touchscreen-fuzz-pressure): the NS2009 supports touch resistance
    calculation from Z1/Z2 and X-plate resistance.

Could you expand the binding description and properties (and show an
interrupt/supply example as well) so we do not have to revisit the
binding when IRQ or pressure support is added later?

Thanks.

-- 
Dmitry

  reply	other threads:[~2026-10-11  5:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-09 14:47 [PATCH 0/3] Add Nsiway NS2009 touchscreen support Miotsuki Mizuno
2026-10-09 14:47 ` [PATCH 1/3] dt-bindings: vendor-prefixes: add Nsiway Miotsuki Mizuno
2026-10-09 14:47 ` [PATCH 2/3] dt-bindings: input: touchscreen: add Nsiway NS2009 Miotsuki Mizuno
2026-10-11  5:13   ` Dmitry Torokhov [this message]
2026-10-09 14:47 ` [PATCH 3/3] Input: add Nsiway NS2009 resistive touchscreen driver Miotsuki Mizuno
2026-10-11  5:42 ` [PATCH v2 0/3] Add Nsiway NS2009 touchscreen support Miotsuki Mizuno
2026-10-11  5:42   ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: add Nsiway Miotsuki Mizuno
2026-10-11  5:42   ` [PATCH v2 2/3] dt-bindings: input: touchscreen: add Nsiway NS2009 Miotsuki Mizuno
2026-10-11  5:42   ` [PATCH v2 3/3] Input: add Nsiway NS2009 resistive touchscreen driver Miotsuki Mizuno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30c56291bac612db47c6ced73dff739f@gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=founder@crepuse.com \
    --cc=icenowy@aosc.io \
    --cc=krzk+dt@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®