[PATCH 0/2] qcom: fix missing dependencies for the QCOM_PD_MAPPER

[PATCH 0/2] qcom: fix missing dependencies for the QCOM_PD_MAPPER

[Dmitry Baryshkov]

While refactoring pd-mapper to use auxiliary bus for the PD mapper
instantiation I forgot to select the bus in Kconfig entries. Fix it now.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
Dmitry Baryshkov (2):
      soc: qcom: add missing pd-mapper dependencies
      remoteproc: qcom: select AUXILIARY_BUS

 drivers/remoteproc/Kconfig | 1 +
 drivers/soc/qcom/Kconfig   | 2 ++
 2 files changed, 3 insertions(+)
---
base-commit: b07e1e375f6389b6715b9aca590da17039bcd447
change-id: 20240626-qcom-pd-mapper-fix-deps-1cf064ee4715

Best regards,
-- 
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

[PATCH 1/2] soc: qcom: add missing pd-mapper dependencies

[Dmitry Baryshkov]

The pd-mapper driver uses auxiliary bus and Qualcomm PDR message format
data. Add missing dependencies to the driver's Kconfig entry.

Reported-by: Mark Brown <broonie@kernel.org>
Fixes: 1ebcde047c54 ("soc: qcom: add pd-mapper implementation")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 drivers/soc/qcom/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index 0a2f2bfd7863..432c85bd8ad4 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -75,6 +75,8 @@ config QCOM_OCMEM
 config QCOM_PD_MAPPER
 	tristate "Qualcomm Protection Domain Mapper"
 	select QCOM_QMI_HELPERS
+	select QCOM_PDR_MSG
+	select AUXILIARY_BUS
 	depends on NET && QRTR
 	default QCOM_RPROC_COMMON
 	help

-- 
2.39.2

Re: [PATCH 1/2] soc: qcom: add missing pd-mapper dependencies

[Chris Lew]

On 6/26/2024 12:12 PM, Dmitry Baryshkov wrote:
> The pd-mapper driver uses auxiliary bus and Qualcomm PDR message format
> data. Add missing dependencies to the driver's Kconfig entry.
> 
> Reported-by: Mark Brown <broonie@kernel.org>
> Fixes: 1ebcde047c54 ("soc: qcom: add pd-mapper implementation")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>   drivers/soc/qcom/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index 0a2f2bfd7863..432c85bd8ad4 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -75,6 +75,8 @@ config QCOM_OCMEM
>   config QCOM_PD_MAPPER
>   	tristate "Qualcomm Protection Domain Mapper"
>   	select QCOM_QMI_HELPERS
> +	select QCOM_PDR_MSG
> +	select AUXILIARY_BUS
>   	depends on NET && QRTR
>   	default QCOM_RPROC_COMMON
>   	help
> 


Reviewed-by: Chris Lew <quic_clew@quicinc.com>

[PATCH 2/2] remoteproc: qcom: select AUXILIARY_BUS

[Dmitry Baryshkov]

The QCOM_PD_MAPPER implementation made Qualcomm remoteproc drivers use
auxiliary bus for the pd-mapper subdevice. Add necessary dependency.

Reported-by: Mark Brown <broonie@kernel.org>
Fixes: 5b9f51b200dc ("remoteproc: qcom: enable in-kernel PD mapper")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 drivers/remoteproc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
index 48845dc8fa85..dda2ada215b7 100644
--- a/drivers/remoteproc/Kconfig
+++ b/drivers/remoteproc/Kconfig
@@ -166,6 +166,7 @@ config QCOM_PIL_INFO
 
 config QCOM_RPROC_COMMON
 	tristate
+	select AUXILIARY_BUS
 
 config QCOM_Q6V5_COMMON
 	tristate

-- 
2.39.2

Re: [PATCH 2/2] remoteproc: qcom: select AUXILIARY_BUS

[Chris Lew]

On 6/26/2024 12:12 PM, Dmitry Baryshkov wrote:
> The QCOM_PD_MAPPER implementation made Qualcomm remoteproc drivers use
> auxiliary bus for the pd-mapper subdevice. Add necessary dependency.
> 
> Reported-by: Mark Brown <broonie@kernel.org>
> Fixes: 5b9f51b200dc ("remoteproc: qcom: enable in-kernel PD mapper")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>   drivers/remoteproc/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index 48845dc8fa85..dda2ada215b7 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -166,6 +166,7 @@ config QCOM_PIL_INFO
>   
>   config QCOM_RPROC_COMMON
>   	tristate
> +	select AUXILIARY_BUS
>   
>   config QCOM_Q6V5_COMMON
>   	tristate
> 


Reviewed-by: Chris Lew <quic_clew@quicinc.com>

Re: (subset) [PATCH 0/2] qcom: fix missing dependencies for the QCOM_PD_MAPPER

[Bjorn Andersson]

On Wed, 26 Jun 2024 22:12:36 +0300, Dmitry Baryshkov wrote:
> While refactoring pd-mapper to use auxiliary bus for the PD mapper
> instantiation I forgot to select the bus in Kconfig entries. Fix it now.
> 
> 

Applied, thanks!

[1/2] soc: qcom: add missing pd-mapper dependencies
      commit: b89c5bc72102469a87f0c6ec0ee7112ef2eba01f

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>