From: Arnd Bergmann <arnd@arndb.de>
To: Sandy Sun <a22017@motorola.com>
Cc: akpm@linux-foundation.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipc/sem: 64bit union semun definition
Date: Tue, 05 May 2015 23:40:17 +0200 [thread overview]
Message-ID: <3111248.ei0HoJaVIp@wuerfel> (raw)
In-Reply-To: <CACwVHNr9K0XXvB8JVEet_OtTRAJmjkHTsKsOc9h5HNts9+X5QA@mail.gmail.com>
On Tuesday 05 May 2015 14:09:14 Sandy Sun wrote:
> Hi Arnd,
>
> If user space uses union semun to define.It will use semid_ds not
> semid64_ds.
>
> I used LTP test case semctl01 IPC_STAT to do the test on 64 bit
> system.According to the test results:
>
> Before the change, semun uses semid_ds, the field of sem_nsems reporting of
> semaphore STAT info is incorrect:
>
> semctl01 1 TFAIL : semaphore STAT info is incorrect
> semctl01 2 TFAIL : semaphore mode info is incorrect
>
> After this change, the return value is correct:
> semctl01 1 TPASS : buf.sem_nsems and buf.sem_perm.mode are correct
> semctl01 2 TPASS : buf.sem_perm.mode is correct
I don't understand: semctl01 does not reference 'union semun64'. How
does this change make a difference, and why would that difference
be limited to 64-bit systems?
Arnd
prev parent reply other threads:[~2015-05-05 21:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 18:28 a22017
2015-05-05 19:37 ` Arnd Bergmann
[not found] ` <CACwVHNr9K0XXvB8JVEet_OtTRAJmjkHTsKsOc9h5HNts9+X5QA@mail.gmail.com>
2015-05-05 21:40 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3111248.ei0HoJaVIp@wuerfel \
--to=arnd@arndb.de \
--cc=a22017@motorola.com \
--cc=akpm@linux-foundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®