Re: [PATCH] media: vimc: add RGB/YUV input entity implementation

[Shuah Khan <skhan@linuxfoundation.org>]

On 11/6/25 22:02, opensource india wrote:
> On Fri, Nov 7, 2025 at 5:41 AM Shuah Khan <skhan@linuxfoundation.org> wrote:
>>
>> On 11/5/25 22:03, opensource india wrote:
>>> Hi Shuah,
>>>
>>> On Wed, Nov 5, 2025 at 10:43 PM Shuah Khan <skhan@linuxfoundation.org> wrote:
>>>>
>>>> On 10/31/25 23:26, Pavan Bobba wrote:
>>>>> Introduce a new vimc-input entity to simulate a color frame source in the
>>>>> Virtual Media Controller (VIMC) pipeline. This entity outputs RGB888 frames
>>>>> and allows testing of pipelines that start from a pre-processed RGB/YUV
>>>>> source instead of a raw Bayer sensor.
>>>>>
>>>>> The patch adds vimc-input.c with basic pad operations for format
>>>>> enumeration, get/set, and stream enable/disable handlers. The entity is
>>>>> registered in the VIMC core configuration, replacing the previous temporary
>>>>> use of vimc-sensor. Frame generation is not yet implemented and remains a
>>>>> TODO for future work.
>>>>>
>>>>> This change enables link validation and format negotiation for the
>>>>> RGB/YUV input path, paving the way for software frame injection and
>>>>> test-pattern generation.
>>>>>
>>>>> Signed-off-by: Pavan Bobba <opensource206@gmail.com>

>>>>
>>>> I see 4 patches - are they dependent then gerenrate a sries
>>>> with cover letter explaining the changes you are making.
>>>>
>>>> thanks,
>>>> -- Shuah
>>>
>>> even though all 4 patches are part of vimc driver,
>>> these are independent patches
>>
>> Independent in the sense that they can be applied and tested
>> independently?
> 
> Yes. all 4 patches can be applied and test independently
> 
Sorry for the delay - these four patches especially this one add
new features/functionality to to vimc.

These require updates - Documentation/admin-guide/media/vimc.rst
Please include the documentation patch - please send these as
series 4 patches + doc patch as a series.

The changes look okay to me.

thanks,
-- Shuah