From: Shuah Khan <skhan@linuxfoundation.org>
To: "Mark Brown" <broonie@kernel.org>, "Willy Tarreau" <w@1wt.eu>,
"Paul E. McKenney" <paulmck@kernel.org>,
"Thomas Weißschuh" <linux@weissschuh.net>
Cc: Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] tools/nolibc: Fix build of stdio.h due to header ordering
Date: Mon, 8 May 2023 11:18:35 -0600 [thread overview]
Message-ID: <31510739-c069-56fc-a1d2-43a0c86aeb2c@linuxfoundation.org> (raw)
In-Reply-To: <20230413-nolibc-stdio-fix-v2-1-6b6bbb045a80@kernel.org>
On 5/8/23 07:30, Mark Brown wrote:
> When we added fd based file streams we created references to STx_FILENO in
> stdio.h but these constants are declared in unistd.h which is the last file
> included by the top level nolibc.h meaning those constants are not defined
> when we try to build stdio.h. This causes programs using nolibc.h to fail
> to build.
>
> Reorder the headers to avoid this issue.
>
> Fixes: d449546c957f ("tools/nolibc: implement fd-based FILE streams")
> Acked-by: Willy Tarreau <w@1wt.eu>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
Applied now to linux-kselftest fixes for 6.4-rc2
thanks,
-- Shuah
prev parent reply other threads:[~2023-05-08 17:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 13:30 Mark Brown
2023-05-08 17:18 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31510739-c069-56fc-a1d2-43a0c86aeb2c@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=paulmck@kernel.org \
--cc=shuah@kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®