From: Joe Perches <joe@perches.com>
To: trix@redhat.com, code@tyhicks.com, hannes@cmpxchg.org,
mhocko@suse.com, longman@redhat.com, herbert@gondor.apana.org.au,
ebiggers@google.com
Cc: ecryptfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] eCryptfs: add a semicolon
Date: Fri, 27 Nov 2020 10:11:23 -0800 [thread overview]
Message-ID: <3168a3aa5c4ac564340cba2a151359e8cd3dee5f.camel@perches.com> (raw)
In-Reply-To: <20201127160513.2619747-1-trix@redhat.com>
On Fri, 2020-11-27 at 08:05 -0800, trix@redhat.com wrote:
> Function like macros should have a semicolon.
[]
> diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c
[]
> @@ -1172,7 +1172,7 @@ decrypt_pki_encrypted_session_key(struct ecryptfs_auth_tok *auth_tok,
> rc = ecryptfs_cipher_code_to_string(crypt_stat->cipher, cipher_code);
> if (rc) {
> ecryptfs_printk(KERN_ERR, "Cipher code [%d] is invalid\n",
> - cipher_code)
> + cipher_code);
As this is the only use that does not have a semicolon,
it'd be good to add the removal of the semicolon from
the #define at the same time.
next prev parent reply other threads:[~2020-11-27 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 16:05 trix
2020-11-27 18:11 ` Joe Perches [this message]
2021-01-30 17:57 ` Tyler Hicks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3168a3aa5c4ac564340cba2a151359e8cd3dee5f.camel@perches.com \
--to=joe@perches.com \
--cc=code@tyhicks.com \
--cc=ebiggers@google.com \
--cc=ecryptfs@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mhocko@suse.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®