* [PATCH 1/1] dmaengine: idxd: remove unused variable 'cdev_ctx'
@ 2021-05-08 6:30 Zhen Lei
2021-05-10 0:26 ` Dave Jiang
0 siblings, 1 reply; 3+ messages in thread
From: Zhen Lei @ 2021-05-08 6:30 UTC (permalink / raw)
To: Dave Jiang, Vinod Koul, Dan Williams, dmaengine, linux-kernel; +Cc: Zhen Lei
GCC reports the following warning with W=1:
drivers/dma/idxd/cdev.c:298:28: warning:
variable 'cdev_ctx' set but not used [-Wunused-but-set-variable]
298 | struct idxd_cdev_context *cdev_ctx;
| ^~~~~~~~
The variable 'cdev_ctx' is not used, remove it to fix the warning.
Fixes: 04922b7445a1 ("dmaengine: idxd: fix cdev setup and free device lifetime issues")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/dma/idxd/cdev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
index 302cba5ff779..6c72089ca31a 100644
--- a/drivers/dma/idxd/cdev.c
+++ b/drivers/dma/idxd/cdev.c
@@ -295,9 +295,7 @@ int idxd_wq_add_cdev(struct idxd_wq *wq)
void idxd_wq_del_cdev(struct idxd_wq *wq)
{
struct idxd_cdev *idxd_cdev;
- struct idxd_cdev_context *cdev_ctx;
- cdev_ctx = &ictx[wq->idxd->data->type];
idxd_cdev = wq->idxd_cdev;
wq->idxd_cdev = NULL;
cdev_device_del(&idxd_cdev->cdev, &idxd_cdev->dev);
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] dmaengine: idxd: remove unused variable 'cdev_ctx'
2021-05-08 6:30 [PATCH 1/1] dmaengine: idxd: remove unused variable 'cdev_ctx' Zhen Lei
@ 2021-05-10 0:26 ` Dave Jiang
2021-05-10 15:57 ` Vinod Koul
0 siblings, 1 reply; 3+ messages in thread
From: Dave Jiang @ 2021-05-10 0:26 UTC (permalink / raw)
To: Zhen Lei, Vinod Koul, Dan Williams, dmaengine, linux-kernel
On 5/7/2021 11:30 PM, Zhen Lei wrote:
> GCC reports the following warning with W=1:
>
> drivers/dma/idxd/cdev.c:298:28: warning:
> variable 'cdev_ctx' set but not used [-Wunused-but-set-variable]
> 298 | struct idxd_cdev_context *cdev_ctx;
> | ^~~~~~~~
>
> The variable 'cdev_ctx' is not used, remove it to fix the warning.
>
> Fixes: 04922b7445a1 ("dmaengine: idxd: fix cdev setup and free device lifetime issues")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Thank you. Issue already reported and fix posted here.
https://lore.kernel.org/dmaengine/324261b0-1fa6-29f7-071a-a3c0ac09b506@intel.com/T/#t
> ---
> drivers/dma/idxd/cdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
> index 302cba5ff779..6c72089ca31a 100644
> --- a/drivers/dma/idxd/cdev.c
> +++ b/drivers/dma/idxd/cdev.c
> @@ -295,9 +295,7 @@ int idxd_wq_add_cdev(struct idxd_wq *wq)
> void idxd_wq_del_cdev(struct idxd_wq *wq)
> {
> struct idxd_cdev *idxd_cdev;
> - struct idxd_cdev_context *cdev_ctx;
>
> - cdev_ctx = &ictx[wq->idxd->data->type];
> idxd_cdev = wq->idxd_cdev;
> wq->idxd_cdev = NULL;
> cdev_device_del(&idxd_cdev->cdev, &idxd_cdev->dev);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] dmaengine: idxd: remove unused variable 'cdev_ctx'
2021-05-10 0:26 ` Dave Jiang
@ 2021-05-10 15:57 ` Vinod Koul
0 siblings, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2021-05-10 15:57 UTC (permalink / raw)
To: Dave Jiang; +Cc: Zhen Lei, Dan Williams, dmaengine, linux-kernel
On 09-05-21, 17:26, Dave Jiang wrote:
>
> On 5/7/2021 11:30 PM, Zhen Lei wrote:
> > GCC reports the following warning with W=1:
> >
> > drivers/dma/idxd/cdev.c:298:28: warning:
> > variable 'cdev_ctx' set but not used [-Wunused-but-set-variable]
> > 298 | struct idxd_cdev_context *cdev_ctx;
> > | ^~~~~~~~
> >
> > The variable 'cdev_ctx' is not used, remove it to fix the warning.
> >
> > Fixes: 04922b7445a1 ("dmaengine: idxd: fix cdev setup and free device lifetime issues")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>
>
> Thank you. Issue already reported and fix posted here.
>
> https://lore.kernel.org/dmaengine/324261b0-1fa6-29f7-071a-a3c0ac09b506@intel.com/T/#t
dropped this
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-10 15:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-08 6:30 [PATCH 1/1] dmaengine: idxd: remove unused variable 'cdev_ctx' Zhen Lei
2021-05-10 0:26 ` Dave Jiang
2021-05-10 15:57 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®