From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Conor Dooley <conor@kernel.org>,
Willow Cunningham <willow.e.cunningham@gmail.com>
Cc: willow.e.cunningham@maine.edu, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Stefan Wahren <wahrenst@gmx.net>,
Andrea della Porta <andrea.porta@suse.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: broadcom: Fix L2 linesize for Raspberry Pi 5
Date: Thu, 10 Oct 2024 09:36:24 -0700 [thread overview]
Message-ID: <31d945d4-0dfa-4494-8377-0cb1be91e41b@broadcom.com> (raw)
In-Reply-To: <20241010-acutely-majesty-c044c7ce6f0a@spud>
On 10/10/24 09:30, Conor Dooley wrote:
> On Thu, Oct 10, 2024 at 11:04:07AM -0400, Willow Cunningham wrote:
>> From: Willow Cunningham <willow.e.cunningham@gmail.com>
>>
>> Fixes: faa3381267d0 ("arm64: dts: broadcom: Add minimal support for
>> Raspberry Pi 5")
>
> This btw Willow, is meant to be...
>
>>
>> Set the cache-line-size parameter of the L2 cache for each core to the
>> correct value of 64 bytes.
>>
>> Previously, the L2 cache line size was incorrectly set to 128 bytes
>> for the Broadcom BCM2712. This causes validation tests for the
>> Performance Application Programming Interface (PAPI) tool to fail as
>> they depend on sysfs accurately reporting cache line sizes.
>>
>> The correct value of 64 bytes is stated in the official documentation of
>> the ARM Cortex A-72, which is linked in the comments of
>> arm64/boot/dts/broadcom/bcm2712.dtsi as the source for cache-line-size.
>>
>
>> Signed-off-by: Willow Cunningham <willow.e.cunningham@maine.edu>
>
> Down here, on the line before your signoff. Perhaps Florian is willing
> to fix that for you though.
Yeah, I will fix it up while applying.
--
Florian
next prev parent reply other threads:[~2024-10-10 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 15:04 Willow Cunningham
2024-10-10 16:30 ` Conor Dooley
2024-10-10 16:36 ` Florian Fainelli [this message]
2024-10-10 23:07 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31d945d4-0dfa-4494-8377-0cb1be91e41b@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrea.porta@suse.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wahrenst@gmx.net \
--cc=willow.e.cunningham@gmail.com \
--cc=willow.e.cunningham@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®