From: Mark Brown <broonie@kernel.org>
To: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.de>, Takashi Iwai <tiwai@suse.com>,
Shuah Khan <shuah@kernel.org>,
linux-sound@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kselftest/alsa: Use card name rather than number in test names
Date: Fri, 12 Jul 2024 19:19:33 +0100 [thread overview]
Message-ID: <31e73e81-e60f-4d0b-b0ac-118f1dc72610@sirena.org.uk> (raw)
In-Reply-To: <c1be6bec-90f5-4bb3-b6b0-8524095fc490@perex.cz>
[-- Attachment #1: Type: text/plain, Size: 789 bytes --]
On Fri, Jul 12, 2024 at 06:25:21PM +0200, Jaroslav Kysela wrote:
> On 12. 07. 24 15:00, Mark Brown wrote:
> > The trouble with the ID field is that it's too short and seems likely to
> > create collisions, for example HDA stuff just seems to default to NVidia
> > for nVidia cards which seems very likely to create collisions if someone
> > has two graphics cards in their system.
> The default IDs are always unique - see snd_card_set_id_no_lock() in
> sound/core/init.c . Basically, the suffix will follow the device probe order
> in this case.
Sure, but the genesis of this patch is that probe order isn't
sufficiently stable and we want to avoid names based on it... using the
ID will be more likely to work out stable than just pure probe order but
it's still got the same issue.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-07-12 18:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 14:33 Mark Brown
2024-07-11 16:08 ` Jaroslav Kysela
2024-07-11 16:19 ` Mark Brown
2024-07-12 8:21 ` Takashi Iwai
2024-07-12 9:20 ` Jaroslav Kysela
2024-07-12 13:00 ` Mark Brown
2024-07-12 16:25 ` Jaroslav Kysela
2024-07-12 18:19 ` Mark Brown [this message]
2024-07-13 6:46 ` Takashi Iwai
2024-07-15 13:18 ` Mark Brown
2024-07-15 13:23 ` Takashi Iwai
2024-07-15 17:31 ` Mark Brown
2024-07-13 7:35 ` Jaroslav Kysela
2024-07-15 12:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31e73e81-e60f-4d0b-b0ac-118f1dc72610@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shuah@kernel.org \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®