mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jaroslav Kysela <perex@perex.cz>
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
	Shuah Khan <shuah@kernel.org>
Cc: linux-sound@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kselftest/alsa: Use card name rather than number in test names
Date: Thu, 11 Jul 2024 18:08:38 +0200	[thread overview]
Message-ID: <7cd921b3-fed9-4b0c-9ba8-381e45ef4218@perex.cz> (raw)
In-Reply-To: <20240711-alsa-kselftest-board-name-v1-1-ab5cf2dbbea6@kernel.org>

On 11. 07. 24 16:33, Mark Brown wrote:
> Currently for the PCM and mixer tests we report test names which identify
> the card being tested with the card number. This ensures we have unique
> names but since card numbers are dynamically assigned at runtime the names
> we end up with will often not be stable on systems with multiple cards
> especially where those cards are provided by separate modules loeaded at
> runtime. This makes it difficult for automated systems and UIs to relate
> test results between runs on affected platforms.
> 
> Address this by replacing our use of card numbers with card names which are
> more likely to be stable across runs. We use the long name since in the
> case where we have two of the same card it is more likely to include
> deduplication information (eg, HDA cards include the address/IRQ). The
> resulting information is not the most beautiful for human readers but the
> majority of kselftest output consumption is automated systems and it wasn't
> that great anyway.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

I think that a combination of card number and card ID may be sufficient (and a 
compromise). It's shorter and user-friendly. Additionally, a table may be 
printed at the beginning of report with card number, card ID and long card 
name for further processing and identification.

					Jaroslav

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.


  reply	other threads:[~2024-07-11 16:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-11 14:33 Mark Brown
2024-07-11 16:08 ` Jaroslav Kysela [this message]
2024-07-11 16:19   ` Mark Brown
2024-07-12  8:21     ` Takashi Iwai
2024-07-12  9:20       ` Jaroslav Kysela
2024-07-12 13:00         ` Mark Brown
2024-07-12 16:25           ` Jaroslav Kysela
2024-07-12 18:19             ` Mark Brown
2024-07-13  6:46               ` Takashi Iwai
2024-07-15 13:18                 ` Mark Brown
2024-07-15 13:23                   ` Takashi Iwai
2024-07-15 17:31                     ` Mark Brown
2024-07-13  7:35               ` Jaroslav Kysela
2024-07-15 12:48                 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7cd921b3-fed9-4b0c-9ba8-381e45ef4218@perex.cz \
    --to=perex@perex.cz \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®