Re: [PATCH 1/1] PM: devfreq: Add missing static storage class specifier in devfreq.c file

Re: [PATCH 1/1] PM: devfreq: Add missing static storage class specifier in devfreq.c file

[MyungJoo Ham]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1046 bytes --]

> Fixes the following sparse warning:
> drivers/devfreq/devfreq.c:30:14: warning: symbol 'devfreq_class' was not declared. Should it be static?
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Signed-off-by: MyungJoo Ham <myunhjoo.ham@samsung.com>

Merged in the devfreq-for-next tree. I'll later send pull a request along with other patches.


Cheers!
MyungJoo.

> ---
>  drivers/devfreq/devfreq.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 70c31d4..9eb6805 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -27,7 +27,7 @@
>  #include <linux/hrtimer.h>
>  #include "governor.h"
>  
> -struct class *devfreq_class;
> +static struct class *devfreq_class;
>  
>  /*
>   * devfreq_work periodically monitors every registered device.
> -- 
> 1.7.4.1
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH 1/1] PM: devfreq: Add missing static storage class specifier in devfreq.c file

[Rahul Bedarkar]

It could be static.

On Wed, Jun 6, 2012 at 11:13 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Fixes the following sparse warning:
> drivers/devfreq/devfreq.c:30:14: warning: symbol 'devfreq_class' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/devfreq/devfreq.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 70c31d4..9eb6805 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -27,7 +27,7 @@
>  #include <linux/hrtimer.h>
>  #include "governor.h"
>
> -struct class *devfreq_class;
> +static struct class *devfreq_class;
>
>  /*
>  * devfreq_work periodically monitors every registered device.
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] PM: devfreq: Add missing static storage class specifier in devfreq.c file

[Sachin Kamat]

Fixes the following sparse warning:
drivers/devfreq/devfreq.c:30:14: warning: symbol 'devfreq_class' was not declared. Should it be static?

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/devfreq/devfreq.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 70c31d4..9eb6805 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -27,7 +27,7 @@
 #include <linux/hrtimer.h>
 #include "governor.h"
 
-struct class *devfreq_class;
+static struct class *devfreq_class;
 
 /*
  * devfreq_work periodically monitors every registered device.
-- 
1.7.4.1