* Re: [PATCH] drm/vboxvideo: Fix a NULL vs IS_ERR() check in vbox_hw_init()
@ 2020-04-30 9:30 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-04-30 9:30 UTC (permalink / raw)
To: Wei Yongjun, dri-devel
Cc: kernel-janitors, linux-kernel, Daniel Vetter, David Airlie,
Hans de Goede
> The devm_gen_pool_create() function returns ERR_PTR() on error, it
> doesn't return NULL so this check doesn't work.
How do you think about a wording variant like the following?
Change description:
A null pointer check was performed after a call of the
function “devm_gen_pool_create” despite of the detail
that failures are indicated by error pointers instead.
Thus adjust a check for the failure predicate
and return the corresponding error code.
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-04-30 9:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-30 9:30 [PATCH] drm/vboxvideo: Fix a NULL vs IS_ERR() check in vbox_hw_init() Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®