From: David Lechner <david@lechnology.com>
To: "Noralf Trønnes" <noralf@tronnes.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Cc: Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Sekhar Nori <nsekhar@ti.com>,
Kevin Hilman <khilman@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD
Date: Wed, 2 Aug 2017 11:24:23 -0500 [thread overview]
Message-ID: <3244660b-64f6-8202-b505-a9796b888db5@lechnology.com> (raw)
In-Reply-To: <32b134d1-84f3-8e3d-1d57-05c8b7c384bc@tronnes.org>
On 08/02/2017 08:03 AM, Noralf Trønnes wrote:
>
>
> Please use tinydrm_xrgb8888_to_gray8().
I considered this, but is seems excessive to loop through the entire fb
twice just to make a 4x6 cursor blink.
> You should use this function to enable the regulator and init the
> controller. Don't look at mi0283qt it should have been fixed.
ACK. But this is why I was not keen on writing a standalone driver. I
know some things about kernel development, but not everything. How am I
supposed to know what is OK to copy from other drivers and what is not?
And if I am going to be put down as the maintainer of this driver, it
bothers me that I don't know so much about how it all works.
>
> Why 2 emulation formats?
> I chose DRM_FORMAT_XRGB8888 since I expected everything to support it.
> Please use only that.
Because my graphics library currently does not work with XRGB8888. ;-)
I can fix the graphics library and drop the RGB565 format in the kernel
driver.
next prev parent reply other threads:[~2017-08-02 16:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 22:11 [PATCH v2 0/4] Support for LEGO MINDSTORMS EV3 LCD display David Lechner
2017-08-01 22:11 ` [PATCH v2 1/4] drm/tinydrm: remove call to mipi_dbi_init() from mipi_dbi_spi_init() David Lechner
2017-08-02 18:53 ` Noralf Trønnes
2017-08-01 22:11 ` [PATCH v2 2/4] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD David Lechner
2017-08-02 13:03 ` Noralf Trønnes
2017-08-02 16:24 ` David Lechner [this message]
2017-08-02 18:49 ` Noralf Trønnes
2017-08-02 14:49 ` Noralf Trønnes
2017-08-10 15:40 ` Rob Herring
2017-08-01 22:11 ` [PATCH v2 3/4] ARM: dts: da850-lego-ev3: Add node for LCD display David Lechner
2017-08-01 22:11 ` [PATCH v2 4/4] ARM: davinci_all_defconfig: enable tinydrm and ST7586 David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3244660b-64f6-8202-b505-a9796b888db5@lechnology.com \
--to=david@lechnology.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=noralf@tronnes.org \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®