From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Martin Kepplinger <martink@posteo.de>
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] acpi: battery: make warning greppable
Date: Wed, 18 Mar 2015 16:27:36 +0100 [thread overview]
Message-ID: <3248282.q652f4oAaQ@vostro.rjw.lan> (raw)
In-Reply-To: <1426204097-3024-1-git-send-email-martink@posteo.de>
On Friday, March 13, 2015 12:48:17 AM Martin Kepplinger wrote:
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---
> I was so angry now, I had to write a change. Please keep things greppable and
> save unnecessary questions and time this way.
Queued up for 4.1, thanks!
> drivers/acpi/battery.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> index d98ba43..baebd1a 100644
> --- a/drivers/acpi/battery.c
> +++ b/drivers/acpi/battery.c
> @@ -530,8 +530,8 @@ static int acpi_battery_get_state(struct acpi_battery *battery)
> battery->rate_now != ACPI_BATTERY_VALUE_UNKNOWN &&
> (s16)(battery->rate_now) < 0) {
> battery->rate_now = abs((s16)battery->rate_now);
> - printk_once(KERN_WARNING FW_BUG "battery: (dis)charge rate"
> - " invalid.\n");
> + printk_once(KERN_WARNING FW_BUG
> + "battery: (dis)charge rate invalid.\n");
> }
>
> if (test_bit(ACPI_BATTERY_QUIRK_PERCENTAGE_CAPACITY, &battery->flags)
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2015-03-18 15:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 23:48 Martin Kepplinger
2015-03-18 15:27 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3248282.q652f4oAaQ@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®